Remove gold/silver/bronze icons from rerun cups

[ezio416]

I'd argue that getting division 2 in a rerun is not really an achievement, so having the indicator that it was my best division is not at all helpful. It should at least be toggleable with the "include reruns" checkbox, or maybe a separate checkbox for indicating best divisions.

[davidbmaier]

Just to clarify, the colors don't show your best division, it's just based on the div number.
Div 1 is green, 2 is gold, 3 is silver, 4 is bronze, everything else is dark grey.
Not 100% intuitive though to be fair.

Either way, the most obvious solution to the confusion is probably just to remove all rerun entries from the table if the checkbox is unchecked. Probably will require some thinking about whether the API will need to be adjusted as well (to prevent the "Load more" button from doing nothing if only reruns get loaded and none of them get shown).

[ezio416]

Are you sure? My best rerun divs now happen to be 2, 3, 4, but before I got those I had 4 marked gold, 8 marked silver, and I think 9 marked bronze, so it seems like it is best divs overall including reruns

[smalljustin]

I would vote for keeping the is-author styling for D1 results, but just removing the coloration for gold/silver/bronze/etc for lower div results for the rerun cups.

The use case here would be "scrolling through the COTD page and seeing an off-color result -> expectation that was a good COTD for them".

I do like your suggestion of "remove reruns from the table when that box is unchecked" as well, though, but I don't think that completely covers this.

[ezio416]

Hmm maybe something changed actually, because this player's best div (asdfghjkl294) is only 5, and nothing is colored. I could've sworn my best divs before were colored as such, not just divs 1-4

[davidbmaier]

I could've sworn my best divs before were colored as such, not just divs 1-4

Just checked the history, I'm pretty sure it's always been like this.

I would vote for keeping the is-author styling for D1 results, but just removing the coloration for gold/silver/bronze/etc for lower div results for the rerun cups.

Ye, I think the other colors are just a little misleading - seeing gold or silver on division 2 or 3 is not really intuitive (especially cause we're showing gold for division rank 1). Maybe a generic highlight for the top X divisions (like 2 and 3?) could still be nice to see at a glance which cups were in the top divs - or just a normal gold/silver/bronze for the top three to make it more obvious what the colors mean.

Not sure how I feel about the idea of treating the reruns differently when it comes to the coloring tbh, it's not easy to communicate the difference clearly. Of course reruns have significantly fewer players, but I think I'd prefer visual consistency over technically being more accurate by e.g. making the colors depend on the achieved div's percentage based on the cup's total number of divs.

Maybe @codecat has some input too?

[smalljustin]

Sorry, I should have clarified - I like having the full D1-4 styling for main COTDs, but I think it should get axed for lower divs. I'll never get div 1, but seeing the couple of D3s/4s stick out on the profile is kind of neat.

I agree it's kind of a pain as far as consistency, though. I had a thought to add a separate color palate for reruns (e.g., a purple D1 instead of the green for those), but I'm not sure that's actually a good idea. Some kind of a by-percentage system could work out, though - like a "D1 is author, >= 10% is gold, >=25% is silver, >=50% is bronze" would be a nice option to have.

[davidbmaier]

Ye, fair points. I just don't like the idea of one div 7 having some colored highlight, and another being grey for no obvious reason. Hoping that people will bother to compare the player numbers isn't amazing UX.
Maybe we could just get away with a tooltip explaining the system, but since this is part of a big table it can easily get overlooked.

For the colors, maybe we could keep the same color scheme for reruns but just make it darker/less saturated? Worth playing around with I think, there might be some intuitive solutions that still stay mostly consistent.

[codecat]

Perhaps we should pick some other color, unrelated to the Author/Gold/Silver/Bronze scheme, and then only show it for non-rerun div1. (Optionally a different color for rerun div1?) That way we keep consistency, and potentially make it clearer.

[davidbmaier]

Had another look at this now that reruns are hidden from the table when they're not explicitly included.
My current plan is to just use the green AT-style color for div 1 reruns and remove special colors from other divs - will be live after the next site deploy.
I think that should take care of most of the issues in here, but of course we can also come up with an extra color if that's needed.