From 24e205e2fb0ba48aa7f70307c24106c8d0d65ca2 Mon Sep 17 00:00:00 2001 From: icey-yu <1186114839@qq.com> Date: Fri, 30 Aug 2024 16:22:23 +0800 Subject: [PATCH 1/2] fix: fill opUser in invite tips --- internal/rpc/group/notification.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/internal/rpc/group/notification.go b/internal/rpc/group/notification.go index e87e7c495b..5c552c1993 100644 --- a/internal/rpc/group/notification.go +++ b/internal/rpc/group/notification.go @@ -567,6 +567,9 @@ func (g *GroupNotificationSender) MemberEnterNotification(ctx context.Context, g return err } tips := &sdkws.MemberInvitedTips{Group: group, InvitedUserList: users, OpUser: opUser} + if err = g.fillOpUser(ctx, &tips.OpUser, tips.Group.GroupID); err != nil { + return nil + } g.setVersion(ctx, &tips.GroupMemberVersion, &tips.GroupMemberVersionID, database.GroupMemberVersionName, tips.Group.GroupID) g.Notification(ctx, mcontext.GetOpUserID(ctx), group.GroupID, constant.MemberInvitedNotification, tips) return nil From 9c9294610f923a4decd11a965e5e8270760fcf5e Mon Sep 17 00:00:00 2001 From: icey-yu <1186114839@qq.com> Date: Fri, 30 Aug 2024 17:05:14 +0800 Subject: [PATCH 2/2] fix: del code --- internal/rpc/group/notification.go | 26 +++----------------------- 1 file changed, 3 insertions(+), 23 deletions(-) diff --git a/internal/rpc/group/notification.go b/internal/rpc/group/notification.go index 5c552c1993..4a69b6aed2 100644 --- a/internal/rpc/group/notification.go +++ b/internal/rpc/group/notification.go @@ -535,28 +535,7 @@ func (g *GroupNotificationSender) MemberEnterNotification(ctx context.Context, g if err := g.conversationRpcClient.GroupChatFirstCreateConversation(ctx, groupID, entrantUserID); err != nil { return err } - opUserID := mcontext.GetOpUserID(ctx) - var opUser *sdkws.GroupMemberFullInfo - if authverify.IsAppManagerUid(ctx, g.config.Share.IMAdminUserID) { - opUser = &sdkws.GroupMemberFullInfo{ - GroupID: groupID, - UserID: opUserID, - AppMangerLevel: constant.AppAdmin, - } - } else { - users, err := g.getGroupMembers(ctx, groupID, []string{opUserID}) - if err != nil { - return err - } - if len(users) == 0 { - opUser = &sdkws.GroupMemberFullInfo{ - GroupID: groupID, - UserID: opUserID, - } - } else { - opUser = users[0] - } - } + var group *sdkws.GroupInfo group, err = g.getGroupInfo(ctx, groupID) if err != nil { @@ -566,7 +545,8 @@ func (g *GroupNotificationSender) MemberEnterNotification(ctx context.Context, g if err != nil { return err } - tips := &sdkws.MemberInvitedTips{Group: group, InvitedUserList: users, OpUser: opUser} + + tips := &sdkws.MemberInvitedTips{Group: group, InvitedUserList: users} if err = g.fillOpUser(ctx, &tips.OpUser, tips.Group.GroupID); err != nil { return nil }