pytz.exceptions.AmbiguousTimeError raised with certain date times formats

[fredkingham]

 from opal.core import serialization
 serialization.deserialize_datetime("29/10/2017 01:00:00")

raises AmbiguousTimeError: 2017-10-29 01:00:00

Solutions are
a) include tz in the datetime input format
b) change the timezone.make_aware call to timezone.make_aware(a, timezone.get_current_timezone(), is_dst=False)

I think we should go with b for the time being.

[davidmiller]

Can we have a better reproduction case?

>>> from opal.core import serialization
>>> serialization.deserialize_datetime("29/10/2017 01:00:00")
datetime.datetime(2017, 10, 29, 1, 0, tzinfo=<UTC>)

[davidmiller]

    def test_deserialize_ambiguous_datetime(self):
        expected = timezone.make_aware(datetime.datetime(2017, 10, 29, 1,0,0))
        value = "29/10/2017 01:00:00"
        self.assertEqual(expected, serialization.deserialize_datetime(value))

(This unittest passes)