Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio Button: Clicking on circle should select option #6228

Open
timotheeg opened this issue May 2, 2023 · 5 comments
Open

Radio Button: Clicking on circle should select option #6228

timotheeg opened this issue May 2, 2023 · 5 comments
Labels
bug Something isn't working contribute free for contributors to pick up

Comments

@timotheeg
Copy link
Contributor

timotheeg commented May 2, 2023

Issue: Clicking circles does not select options, only text selects

Image

Expected behaviour (confirmed by @staceytan1998 ):
You should be able to select the option by clicking on the circle or the text!

Issue possibly (likely?) also applies to checkboxes.

@timotheeg timotheeg added bug Something isn't working contribute free for contributors to pick up labels May 2, 2023
@jia1
Copy link
Member

jia1 commented Jul 2, 2023

I can't reproduce this bug on any of my platforms.

What I did:

  • Pulled develop branch (4a92e31).
  • Ran the repo locally.
  • Created a test form containing Radio and Checkbox.
  • In the form builder, clicked the circle. Selection worked. Clicked the text, selection worked too.
  • Submitted form by selecting with button for one option and selecting with text for the other option. Submission meets expectations.
  • Repeat the above for Preview form and public form.
  • Repeat the above for form.gov.sg (production). No problem.
  • Repeat the above for form.gov.sg in my mobile phone (Android). No problem.

@timotheeg
Copy link
Contributor Author

Thanks for checking this @jia1

I did a quick test and I similarly can no longer reproduce this issue.

I should have linked to the form that did give me the issue, so we could check if a combination of factors affects behaviour in that form specifically, and whether that has been fixed.

Since I didn't link to the form, I'm just going to close the issue, and we can open it again if the behaviour ever happens again.

@timotheeg
Copy link
Contributor Author

K, I manage to repro after all!!

The bug manifests itself IF some text is selected on the page.

This seems to be a chakra bug, reported here, and it seems to be fixed in chakra 2, so we should ge the fix "for free" when we are ready to upgrade react+chakra.

@timotheeg timotheeg reopened this Jul 12, 2023
@LoneRifle
Copy link
Contributor

LoneRifle commented Jun 28, 2024

Issue still persists as of this day

@adriangohjw
Copy link
Contributor

Unfortunately, Chakra 2 is not backward compatible with React 17 (Ref: https://v2.chakra-ui.com/getting-started/migration), and the upgrade from React 17 to 18 itself causes more potential breaking changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working contribute free for contributors to pick up
Projects
None yet
Development

No branches or pull requests

4 participants