Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set psi4 memory #169

Closed
wants to merge 2 commits into from
Closed

set psi4 memory #169

wants to merge 2 commits into from

Conversation

sef43
Copy link

@sef43 sef43 commented Jul 5, 2024

Description

will fix #168
enables setting the psi4 memory limit with running resp.

This works for my purposes. I can now run resp on larger molecules without psi4 complaining about hitting the memory limits.

Happy to change syntax/ implementation to whatever you prefer

Status

  • Ready to go

@lilyminium
Copy link
Contributor

Thanks @sef43 for opening this and glad to see it works for you! I think in general OpenFF Recharge would prefer using an OpenFF units based solution instead of asking everyone to convert to GB, especially as it seems that by default psi4 assumes 500 MiB is available. It'd also be best to have a default value for the memory argument to avoid breaking people's existing scripts as well. Happy to both work with you to do this if you're interested or to tinker myself during some flights. (As a note to self, it'll probably involve printing a unit quantity with a symbol with f"{q:~P}".)

@sef43
Copy link
Author

sef43 commented Jul 8, 2024

thanks @lilyminium !

Will close this one in favour of yours #170

@sef43 sef43 closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set PSI4 memory limit
2 participants