-
-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Citi Vouchers] Add VINE connected app #12855
Comments
On the tasks:
|
I am bit sceptical on not checking the PAT when turning on the connected app. It would make tracking down a wrong PAT harder, as we will probably realised the PAT is wrong when a customer tries to redeem a voucher for the first time, plus it would lead to a bad UX. It should be pretty quick to check the PAT directly against the API and provide the ability to re enter the PAT if doesn't work. Agreed on not doing that in the background. @maikel What do you think ? |
Yes, I'm happy for that, too. Definitely better UX. |
just commenting that I belatedly saw @RachL suggestion about possibly doing this on the voucher page and I quite liked. Perhaps one for delivery circle tonight |
Updated the estimate with more details on this is going to work, based on Maikel's feedback |
Description
See https://docs.google.com/presentation/d/1PcYNqh_2YNJ0GIaI7DDQPdKsLe5OFL5zlPl1v1ZMHmw/edit#slide=id.g279a7e25fac_0_0 for requirements
Estimation
Assumptions:
Tasks:
Total : 1.75 days , add 20% to cover unforeseen issue
Estimation total: 2.1 days
Acceptance Criteria & Tests
The text was updated successfully, but these errors were encountered: