OEL-2261: Override unformatted pattern for correct layout margins. #315
Conversation
There was a problem hiding this comment.
I don't think its mandatory but I agree with the principle that the list can define the margins.
That being said we have to be sure its backwards compatible, and there could be other types of views (other than unformatted) where this variant has been used. Also this template might already been overridden.
This looks rather like a ticket for V2, or maybe (not sure its worth it) we can add a parameter that removes the mb-3.
| {# | ||
| /** | ||
| * @file | ||
| * Template for a unformatted rows. |
There was a problem hiding this comment.
The english here is not correct, but I would change it completely to "Theme override to display a view of unformatted rows."
| * Template for a unformatted rows. | ||
| */ | ||
| #} | ||
| {% if title %} |
There was a problem hiding this comment.
would the bcl heading template be suited here?
| {% for row in rows %} | ||
| {% | ||
| set row_classes = [ | ||
| 'col', |
There was a problem hiding this comment.
the result of this is not the same as mb-3, I checked, the spacing is not the same
|
I agree with @drishu , we cannot remove the class without changing the behaviour for existing websites. |
Jira issue(s):