Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discussion errors in the demo course #276

Closed
kdmccormick opened this issue Mar 22, 2023 · 7 comments
Closed

Discussion errors in the demo course #276

kdmccormick opened this issue Mar 22, 2023 · 7 comments
Assignees
@mariajgrimaldi @DmytroAlipov
Labels
bug Report of or fix for something that isn't working as intended palm
Milestone
Palm.2

Comments

@kdmccormick
Copy link
Member

kdmccormick commented Mar 22, 2023 •
edited
Loading

Issue

Many units in the demo course show an overlay saying "The discussion could not be loaded.":

image

Clicking OK removes the overlay and lets the user continue as normal, but this happens in many units and is annoying.

Notes

  • I did confirm this on the demo course in the Palm instance. However, it has been the case for a while, at least back to Nutmeg and maybe earlier.
  • This does not happen in the test course in the Palm instance. I'm not sure why it's different.
  • @bmtcril tried a couple things on his local instance:
    • He tried disabling discussions via Django admin. That didn't fix the error.
    • He enabled the tutor-forum plugin and restarted. This did resolved the error. However, since tutor-forum isn't enabled by default, we need a way of avoiding the error without enabling the forums.
  • @feanil thinks that disabling the ENABLE_DISCUSSION_SERVICE toggle when tutor-forum is not enabled might resolve the issue.
@kdmccormick kdmccormick self-assigned this Mar 22, 2023
@kdmccormick kdmccormick changed the title Demo course in default install throws discussions errors Discussion errors in the demo course Apr 27, 2023
@kdmccormick kdmccormick transferred this issue from openedx-unsupported/wg-developer-experience Apr 27, 2023
@jalondonot jalondonot added this to the Palm.1 milestone May 15, 2023
@jalondonot
Copy link

Hi, @kdmccormick! Have you had a chance to continue working on this? :)

@kdmccormick
Copy link
Member Author

Sorry, I have not! I do not know when I will have time to work on this again. If anyone else is able to take a look that would be amazing.

@kdmccormick kdmccormick removed their assignment May 31, 2023
@kdmccormick kdmccormick added the bug Report of or fix for something that isn't working as intended label Jun 7, 2023
@pdpinch
Copy link

pdpinch commented Jun 14, 2023

Should the release notes include this as a "known issue"? If so please propose some text on the release notes PR at openedx/docs.openedx.org#321

@DmytroAlipov DmytroAlipov mentioned this issue Jun 14, 2023
Merged
@DmytroAlipov
Copy link

@pdpinch @kdmccormick I have resolved this issue ;)

@DmytroAlipov DmytroAlipov mentioned this issue Jun 14, 2023
Merged
DmytroAlipov added a commit to DmytroAlipov/edx-platform that referenced this issue Jun 14, 2023
@DmytroAlipov
fix: discussion errors in the demo course for Palm
a9f6670 
Discussion:
 - openedx/wg-build-test-release#276
@mariajgrimaldi
Copy link
Member

@DmytroAlipov: thank you so much! I'll review the PR against the master branch as soon as possible.

DmytroAlipov added a commit to DmytroAlipov/edx-platform that referenced this issue Jul 18, 2023
@DmytroAlipov
fix: discussion errors in the demo course
01f4218 
Discussion:
 - openedx/wg-build-test-release#276
@mariajgrimaldi mariajgrimaldi modified the milestones: Palm.1, Palm.2 Jul 24, 2023
mariajgrimaldi pushed a commit to openedx/edx-platform that referenced this issue Jul 24, 2023
@DmytroAlipov
fix: discussion could not be loaded in course units (#32456)
bf74a8b 
Discussion:
 - openedx/wg-build-test-release#276
mariajgrimaldi pushed a commit to openedx/edx-platform that referenced this issue Aug 1, 2023
@DmytroAlipov @e0d
fix: discussion errors in the demo course for Palm (#32464)
085987e 
Discussion:
 - openedx/wg-build-test-release#276

Co-authored-by: Edward Zarecor <[email protected]>
@mariajgrimaldi
Copy link
Member

The fix contributed by @DmytroAlipov was already merged to the palm.master branch. Thank you. I'll be closing this then! If you have any of you folks have an objection, you can reopen this issue explaining why ;)

yusuf-musleh pushed a commit to open-craft/edx-platform that referenced this issue Aug 10, 2023
@DmytroAlipov @e0d @yusuf-musleh
fix: discussion errors in the demo course for Palm (openedx#32464)
448295f 
Discussion:
 - openedx/wg-build-test-release#276

Co-authored-by: Edward Zarecor <[email protected]>
@kdmccormick
Copy link
Member Author

Thank you Dmytro and Maria!

bra-i-am pushed a commit to eduNEXT/edunext-platform that referenced this issue Apr 16, 2024
@DmytroAlipov @e0d @bra-i-am
fix: discussion errors in the demo course for Palm (#32464)
f01b41d 
Discussion:
 - openedx/wg-build-test-release#276

Co-authored-by: Edward Zarecor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mariajgrimaldi mariajgrimaldi

@DmytroAlipov DmytroAlipov

Labels
bug Report of or fix for something that isn't working as intended palm
Projects
Build-Test-Release Working Group
Status: Done
Milestone
Palm.2
Development

No branches or pull requests
5 participants
@pdpinch @kdmccormick @jalondonot @mariajgrimaldi @DmytroAlipov