Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LMS > Instructor dashboard > data download] text styling and layout issue in the table #225

Open
fayyazahmed66 opened this issue Nov 1, 2022 · 9 comments
Assignees
Labels
enhancement Relates to new features or improvements to existing features release testing Affects the upcoming release (attention needed)
Milestone

Comments

@fayyazahmed66
Copy link

Steps to reproduce:

  1. Go to the lms > Instructor dashboard > data download
  2. Check the report
    Expected result:
    The report text layout should be properly styled.
    Actual result:
    Styling issue

text style

@fayyazahmed66
Copy link
Author

label: olive testing

@github-actions github-actions bot added the release testing Affects the upcoming release (attention needed) label Nov 1, 2022
@johnny243
Copy link

Hey @fayyazahmed66, this looks like a first good issue. Do you mind if I work on it?

@fayyazahmed66
Copy link
Author

@johnny243 sure you can.

@arbrandes arbrandes added this to the Olive.1 milestone Dec 6, 2022
@arbrandes arbrandes added the bug Report of or fix for something that isn't working as intended label Dec 6, 2022
@arbrandes arbrandes modified the milestones: Olive.1, Olive.2 Dec 12, 2022
@jalondonot
Copy link

Hi @johnny243. Have you been able to make some progress on this issue? please let us know if you need help from the community :)

@johnny243
Copy link

Hey @jalondonot thanks for reminding me about this task :)

I was able to narrow down the styling issue to the slickgrid library. Updating to the latest version fixes the issue:

image

I will create a PR with a fix shortly.

@jalondonot
Copy link

Thanks, @johnny243 ! did you get a chance to create the PR to fix this issue?

@johnny243
Copy link

@jalondonot yes, you can see it linked right below my previous comment

@jalondonot jalondonot modified the milestones: Olive.2, Olive.3 Mar 6, 2023
@jalondonot jalondonot removed this from the Olive.3 milestone May 15, 2023
@mariajgrimaldi
Copy link
Member

Update: the PR is waiting for a review.

@mariajgrimaldi mariajgrimaldi added this to the Quince.3 milestone Mar 27, 2024
@mariajgrimaldi mariajgrimaldi modified the milestones: Quince.3, Redwood.1 Apr 26, 2024
@mariajgrimaldi
Copy link
Member

Update: the PR was closed due to inactivity.

@mariajgrimaldi mariajgrimaldi added enhancement Relates to new features or improvements to existing features and removed bug Report of or fix for something that isn't working as intended labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Relates to new features or improvements to existing features release testing Affects the upcoming release (attention needed)
Projects
Status: In progress
Development

No branches or pull requests

5 participants