Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add header styles inclusion #322

Draft
wants to merge 1 commit into
base: open-release/quince.master
Choose a base branch
from

Conversation

Lunyachek
Copy link

@Lunyachek Lunyachek commented Mar 14, 2024

This is backport from master branch - #321

Header styles inclusion like it done in frontend-app-learning - https://github.com/openedx/frontend-app-learning/blob/master/src/index.scss#L7

It can be useful, for example, for the potential using of cookie banner

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 14, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Mar 14, 2024

Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c644da3) to head (e97d078).

Additional details and impacted files
@@                     Coverage Diff                      @@
##           open-release/quince.master      #322   +/-   ##
============================================================
  Coverage                      100.00%   100.00%           
============================================================
  Files                             110       110           
  Lines                            1079      1079           
  Branches                          159       159           
============================================================
  Hits                             1079      1079           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Mar 15, 2024
@feanil feanil requested review from a team and removed request for a team March 20, 2024 15:07
@arbrandes
Copy link
Contributor

Marking as draft until master is merged.

@arbrandes arbrandes marked this pull request as draft March 20, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

4 participants