Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "Add to collection" on the component sidebar #1287

Open
Tracked by #1084
rpenido opened this issue Sep 16, 2024 · 7 comments
Open
Tracked by #1084

Implement "Add to collection" on the component sidebar #1287

rpenido opened this issue Sep 16, 2024 · 7 comments

Comments

@rpenido
Copy link
Contributor

rpenido commented Sep 16, 2024

As a library author, I want to associate the selected component with one of more collections:

image

As a library author, I want to remove a component from a collection.

Screenshot

@pomegranited
Copy link
Contributor

@rpenido We need to be able to remove a component from a collection too.. Could you update this ticket to cover that?

I don't see a screen on Figma for this, but we can borrow the way Tags do it with the little "x" button:

image

@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Sep 26, 2024

@pomegranited @rpenido Instead of that, please add a "Remove from collection" to the three dot menu for components in a collection context. And keep this widget as only an "Add" widget. CC @jmakowski1123 @sdaitzman

I've updated this ticket to include that three-dot menu change too.

@bradenmacdonald
Copy link
Contributor

@jmakowski1123 @sdaitzman I put a mockup of the "Remove from [Collection Name]" three-dot menu above. Please review and let me know if you have changes.

@jmakowski1123
Copy link

I prefer the 3-dot approach. Defer to @sdaitzman for final call.

@pomegranited
Copy link
Contributor

@sdaitzman CC @jmakowski1123 @bradenmacdonald @rpenido a component can live in multiple collections.. how would that work with the 3-dot menu?

@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Sep 27, 2024

@pomegranited You only see that menu if you're currently "in" a collection. And then it removes it from whichever collection you're in. If you're just using the general library home page / search, you can't remove components from collections with the three dot menu.

e.g. from this collection you can remove the items from "Studio Advanced" regardless of what other collections they're in. From this page you can't remove items from any collection.

@navinkarkera
Copy link
Contributor

@bradenmacdonald @pomegranited Should we display already selected collections as checked in the collections section in component sidebar? This way we can also remove or add i.e. update the collections for a component from any page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

5 participants