fix: remove unused JWT_AUTH_REFRESH_COOKIE #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmc-edx
approved these changes
Jul 6, 2023
|
I have a PR up to fix the mysqlclient issue that's causing your tests to fail: #364 |
|
The other PR is merged now, so your tests should pass now if you rebase (or merge down to your branch.) |
Remove the setting JWT_AUTH_REFRESH_COOKIE which serves no purpose. See DEPR: openedx/public-engineering#190
robrap
force-pushed
the
robrap/DEPR-JWT_AUTH_REFRESH_COOKIE
branch
from
9fb3e1e
to
4cc7487
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the setting JWT_AUTH_REFRESH_COOKIE
which serves no purpose.
See DEPR: openedx/public-engineering#190
Merge checklist:
Check off if complete or not applicable: