Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.0.0 Ray Operator #159

Closed
wants to merge 1 commit into from

Conversation

jbusche
Copy link
Contributor

@jbusche jbusche commented Nov 15, 2023

Closes #158
Updating from 0.6.0 to the newly released 1.0.0 KubeRay Operator
CC: @anishasthana @tedhtchang @KPostOffice

Description

  • updated KubeRay Operator version in README.md
  • updated CRDs
  • updated image

How Has This Been Tested?

I'm not sure how to test it with DSC install method, but I've deployed my branch with the kfdef method of install, and it looked good.

Steps to deploy/test

1.  vi codeflare-stack-kfdef.yaml
and change the tarball to point to my branch
    #uri: https://github.com/opendatahub-io/distributed-workloads/tarball/main
    uri: https://github.com/jbusche/distributed-workloads/tarball/kuberay-100

2.  Deploy ODH 1.11.0 from rolling channel
Deploy the CodeFlare from alpha channel 1.0.0
Deploy the KFDEFs
oc apply -f https://raw.githubusercontent.com/opendatahub-io/odh-manifests/master/kfdef/odh-core.yaml -n opendatahub
# Use the modified kfdef that uses my branch:
oc apply -f codeflare-stack-kfdef.yaml

3.  Check that the KubeRay is using 1.0.0
oc describe deploy kuberay-operator  |grep Image:
    Image:      quay.io/kuberay/operator:v1.0.0

4. Deploy the 0_basic_ray.ipynb and 2_basic_jobs.ipynb notebook items for testing

5.  Check that the Ray cluster runs right
oc get raycluster -n default
NAME      DESIRED WORKERS   AVAILABLE WORKERS   STATUS   AGE
jobtest   2                 2                   ready    11m

6. Check that the sample job completes:
AppStatus:
  msg: <NONE>
  num_restarts: -1
  roles:
  - replicas:
    - hostname: ''
      id: 0
      role: mnist
      state: !!python/object/apply:torchx.specs.api.AppState
      - 2
      structured_error_msg: <NONE>
    role: mnist
  state: RUNNING (3)
  structured_error_msg: <NONE>
  ui_url: null

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: James Busche <[email protected]>
Copy link

openshift-ci bot commented Nov 15, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jbusche. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jbusche
Copy link
Contributor Author

jbusche commented Nov 15, 2023

/retest-required

Copy link

openshift-ci bot commented Nov 15, 2023

@jbusche: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-odh-dw 87734a4 link true /test e2e-odh-dw

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@anishasthana
Copy link
Member

/hold

@sutaakar
Copy link
Contributor

KubeRay for ODH is now located in https://github.com/opendatahub-io/kuberay
Closing PR as not relevant any more.

@sutaakar sutaakar closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KubeRay v1.0.0 release is out, need to update from 0.6.0 to 1.0.0
3 participants