Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ESLint configuration #713

Open
JulianKniephoff opened this issue Jun 19, 2024 · 1 comment
Open

Change ESLint configuration #713

JulianKniephoff opened this issue Jun 19, 2024 · 1 comment

Comments

@JulianKniephoff
Copy link
Member

JulianKniephoff commented Jun 19, 2024 •
edited
Loading

Probably to @opencast/eslint-config-ts-react.

This would increase consistency between our frontend projects, and also let us get rid of a number of symptoms of us using what is basically unmaintained code:

  • We currently use eslint-config-react-app, which is unmaintained.
  • That holds back our ESLint version at the 8 release branch.
  • It also forces the @eslint/eslintrc compatibility package on us.
  • It also makes us depend on @babel/plugin-proposal-private-property-in-object because of a bug in a transitive dependency, which will never be fixed.
  • It holds back our version of @typescript-eslint/typescript-estree at a version that is not compatible with the TypeScript version we use. This is probably fine (for now), but generates a fat warning during linting.
  • It also generates a bunch of deprecation warnings during npm ci.
JulianKniephoff added a commit to JulianKniephoff/opencast-admin-interface that referenced this issue Jun 19, 2024
@JulianKniephoff
"Restore" ESLint support
a171880 
I removed our leftover config in opencast#700 with a promise to bring ESLint back.
Well this is it, for now!

This introduces an ESLint config file in the new flat file format,
which will be required for ESLint `>= 9`. It is already supported in version 8, though,
which we are still stuck on because of the (unmaintained) config we are/were using.
I briefly tried to port this project over to `@opencast/eslint-config-ts-react`,
but the code said "no," basically. ;P

This has a few unfortunate consequences. See opencast#713. I plan to address these in due time, though.

Note that this does **not** introduce automatic/live checking of the code
during development. I only added a call to the linter to the build command,
in turn making CI fail when there are warnings.
I created opencast#712 to track the live thing if we want that.
@JulianKniephoff JulianKniephoff mentioned this issue Jun 19, 2024
Merged
@Arnei
Copy link
Member

Arnei commented Jun 20, 2024

I for one have no attachment whatsoever to eslint-config-react-app and am all in favor of using our own.

JulianKniephoff added a commit to JulianKniephoff/opencast-admin-interface that referenced this issue Jun 25, 2024
@JulianKniephoff
"Restore" ESLint support
9fbe75d 
I removed our leftover config in opencast#700 with a promise to bring ESLint back.
Well this is it, for now!

This introduces an ESLint config file in the new flat file format,
which will be required for ESLint `>= 9`. It is already supported in version 8, though,
which we are still stuck on because of the (unmaintained) config we are/were using.
I briefly tried to port this project over to `@opencast/eslint-config-ts-react`,
but the code said "no," basically. ;P

This has a few unfortunate consequences. See opencast#713. I plan to address these in due time, though.

Note that this does **not** introduce automatic/live checking of the code
during development. I only added a call to the linter to the build command,
in turn making CI fail when there are warnings.
I created opencast#712 to track the live thing if we want that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JulianKniephoff @Arnei