-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow tracks in event asset upload #698
base: main
Are you sure you want to change the base?
Allow tracks in event asset upload #698
Conversation
Old logic dictates that media of type track cannot be in the asset upload tab of the event details or new event wizard. Since subtitles are now tracks, this logic finally breaks. Instead of relying on checking for type track to differentiate between options for source upload and asset upload, this commit instead uses the key in the list provider that is there for this exact purpose.
Use Run test server using develop.opencast.org as backend:
Specify a different backend like stable.opencast.org:
It may take a few seconds for the interface to spin up. |
This pull request is deployed at test.admin-interface.opencast.org/698/2024-08-09_12-23-28/ . |
This pull request has conflicts ☹ |
…up-in-asset-upload
This pull request has conflicts ☹ |
…up-in-asset-upload
…up-in-asset-upload
This pull request has conflicts ☹ |
…up-in-asset-upload
6200751
to
1c411b6
Compare
This pull request has conflicts ☹ |
…up-in-asset-upload
This pull request has conflicts ☹ |
…up-in-asset-upload
This pull request has conflicts ☹ |
…up-in-asset-upload
This pull request has conflicts ☹ |
…up-in-asset-upload
Old logic dictates that media of type track cannot be in the asset upload tab of the event details or new event wizard. Since subtitles are now tracks, this logic finally breaks.
Instead of relying on checking for type track to differentiate between options for source upload and asset upload, this commit instead uses the key in the list provider that is there for this exact purpose.
To review this, you will need an Opencast with Asset Upload configured. Check the Opencast docs on how to do that https://docs.opencast.org/develop/admin/#configuration/admin-ui/asset-upload/#manual-asset-upload. This changes behaviour for both the event details and the create event dialog.
Fixes #694.