Update rubocop-rails 2.24.1 → 2.26.2 (minor) #3453

depfu · 2024-09-28T04:16:09Z

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rails (2.24.1 → 2.26.2) · Repo · Changelog

Release Notes

2.26.2

Bug fixes

#1362: Fix false positives for Rails/EnumSyntax when using Ruby 2.7. (@koic)

#1269: Fix false positives for Rails/ActionControllerFlashBeforeRender in combination with implicit returns. (@earlopain)

#1326: Fix wrong autocorrect for Rails/FilePath when passing an array to File.join. (@earlopain)

Changes

#1359: Support filter in Rails/CompactBlank. (@masato-bkn)

2.26.1

Bug fixes

#1343: Fix false negatives for Rails/EnumSyntax for non-literal mappings. (@earlopain)

#1340: Fix a false positive for Rails/WhereEquals, Rails/WhereNot, and Rails/WhereRange when qualifying the database name. (@earlopain)

Changes

#1342: Change Rails/ApplicationRecord to ignore migrations. (@fatkodima)

#1350: Change Rails/EnumSyntax to autocorrect underscored options. (@fatkodima)

2.26.0

New features

#1238: Add new Rails/EnumSyntax cop. (@maxprokopiev, @koic)

#1309: Support Rails 7 syntax for Rails/EnumHash cop. (@ytjmt)

#1298: Support Rails 7 syntax for Rails/EnumUniqueness cop. (@ytjmt)

Bug fixes

#1335: Fix an error for Rails/BulkChangeTable when the block for change_table is empty. (@earlopain)

#1325: Fix an error for Rails/RenderPlainText when the content type is passed as a constant. (@earlopain)

#1337: Fix an error for Rails/Validation when passing no arguments. (@earlopain)

#1330: Fix an error for Rails/WhereNot when using placeholder without second argument. (@earlopain)

#1311: Fix false negatives for Rails/ActionControllerFlashBeforeRender when using implicit render or rescue blocks. (@tldn0718)

#1313: Fix false positives for Rails/CompactBlank when using collection.reject!. (@koic)

#1319: Fix a false positive for Rails/RedundantPresenceValidationOnBelongsTo when removing presence would leave other non-validation options like allow_blank without validations. (@earlopain)

#1306: Make Rails/PluralizationGrammar aware of byte methods. (@earlopain)

#1302: Allow params receiver by default for Style/CollectionMethods. (@koic)

#1321: Fix an error for Rails/WhereEquals when the second argument is not yet typed (where("foo = ?", )). (@earlopain)

Changes

#1308: Change Rails/CompactBlank to handle select(&:present?). (@fatkodima)

#1303: Change Rails/IgnoredSkipActionFilterOption to handle multiple callbacks. (@fatkodima)

#1199: Make Rails/WhereEquals aware of where.not(...). (@earlopain)

#1003: Change Rails/RootPathnameMethods to detect offenses on Dir.[]. (@r7kamura)

2.25.1

Bug fixes

#1280: Look for change_column_null for Rails/BulkChangeTable. (@ccutrer)

#1299: Fix an error for Rails/NotNullColumn when the block for change_table is empty. (@earlopain)

#1281: Fix Rails/WhereRange autocorrect for complex expressions. (@fatkodima)

#1282: Fix Rails/WhereRange to correctly handle template strings with extra spaces. (@fatkodima)

Changes

#1295: Cover validates_comparison_of in Rails/Validation. (@ChaelCodes)

#1288: Let Rails/LinkToBlank look into link_to_if and link_to_unless, too. (@fwolfst)

#1286: Mark Rails/SkipsModelValidations as unsafe. (@koic)

#1283: Mark Rails/WhereRange as unsafe autocorrect. (@fatkodima)

2.25.0

New features

#1272: Add new Rails/WhereRange cop. (@fatkodima)

Bug fixes

#1270: Fix an incorrect autocorrect for Rails/Validation when using validates_size_of. (@koic)

#1278: Fix a false positive for Rails/SkipsModelValidations when using insert or insert! with a safe navigator. (@tldn0718)

#1260: Fix a performance regression caused by Rails/UnknownEnv when using Rails 7.1. (@lukasfroehlich1)

Changes

#1249: Disable Rails/UnusedIgnoredColumns by default. (@earlopain)

#1266: Check change_table calls for offenses. (@ccutrer)

#1267: Make Rails/HttpStatus aware of Rails-specific response assertions. (@tldn0718)

#1137: Migrate to TargetRailsVersion the new requires_gem API. (@amomchilov)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

✳️ rexml (3.3.6 → 3.3.7) · Repo · Changelog

Release Notes

3.3.7

Improvements

Added local entity expansion limit methods

GH-192

GH-202

Reported by takuya kodama.

Patch by NAITOH Jun.

Removed explicit strscan dependency

GH-204

Patch by Bo Anderson.

Thanks

takuya kodama

NAITOH Jun

Bo Anderson

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 6 commits:

✳️ rubocop (1.65.0 → 1.66.1) · Repo · Changelog

Release Notes

1.66.1

Bug fixes

#13191: Fix an error for Style/IfWithSemicolon when using nested single-line if/;/end in block of if/else branches. (@koic)

#13178: Fix false positive for Style/EmptyLiteral with Hash.new([]). (@earlopain)

#13176: Fix crash in Style/EmptyElse when AllowComments: true and the else clause is missing. (@vlad-pisanov)

#13185: Fix false negatives in Style/MapIntoArray autocorrection when using ensure, def, defs and for. (@vlad-pisanov)

1.66.0

New features

#13077: Add new global StringLiteralsFrozenByDefault option for correct analysis with RUBYOPT=--enable=frozen-string-literal. (@earlopain)

#13080: Add new DocumentationExtension global option to serve documentation with extensions different than .html. (@earlopain)

#13074: Add new Lint/UselessNumericOperation cop to check for inconsequential numeric operations. (@zopolis4)

#13061: Add new Style/RedundantInterpolationUnfreeze cop to check for dup and @+ on interpolated strings in Ruby >= 3.0. (@earlopain)

Bug fixes

#13093: Fix an error for Lint/ImplicitStringConcatenation when implicitly concatenating a string literal with a line break and string interpolation. (@koic)

#13098: Fix an error for Style/IdenticalConditionalBranches when handling empty case branches. (@koic)

#13113: Fix an error for Style/IfWithSemicolon when a nested if with a semicolon is used. (@koic)

#13097: Fix an error for Style/InPatternThen when using alternative pattern matching deeply. (@koic)

#13159: Fix an error for Style/OneLineConditional when using if/then/else/end with multiple expressions in the then body. (@koic)

#13092: Fix an incorrect autocorrect for Layout/EmptyLineBetweenDefs when two method definitions are on the same line separated by a semicolon. (@koic)

#13116: Fix an incorrect autocorrect for Style/IfWithSemicolon when a single-line if/;/end has an argument in the then body expression. (@koic)

#13161: Fix incorrect autocorrect for Style/IfWithSemicolon when using multiple expressions in the else body. (@koic)

#13132: Fix incorrect autocorrect for Style/TrailingBodyOnMethodDefinition when an expression precedes a method definition on the same line with a semicolon. (@koic)

#13164: Fix incorrect autocorrect behavior for Layout/BlockAlignment when EnforcedStyleAlignWith: either (default). (@koic)

#13087: Fix an incorrect autocorrect for Style/MultipleComparison when expression with more comparisons precedes an expression with less comparisons. (@fatkodima)

#13172: Fix an error for Layout/EmptyLinesAroundExceptionHandlingKeywords when ensure or else and end are on the same line. (@koic)

#13107: Fix an error for Lint/ImplicitStringConcatenation when there are multiple adjacent string interpolation literals on the same line. (@koic)

#13111: Fix an error for Style/GuardClause when if clause is empty and correction would not fit on single line because of Layout/LineLength. (@earlopain)

#13137: Fix an error for Style/ParallelAssignment when using __FILE__. (@earlopain)

#13143: Fix an error during TargetRubyVersion detection if the gemspec is not valid syntax. (@earlopain)

#13131: Fix false negatives for Lint/Void when using ensure, defs and numblock. (@vlad-pisanov)

#13174: Fix false negatives for Style/MapIntoArray when initializing the destination using Array[], Array([]), or Array.new([]). (@vlad-pisanov)

#13173: Fix false negatives for Style/EmptyLiteral when using Array[], Hash[], Array.new([]) and Hash.new([]). (@vlad-pisanov)

#13126: Fix a false positive for Style/Alias when using multiple alias in def. (@koic)

#13085: Fix a false positive for Style/EmptyElse when a comment-only else is used after elsif and AllowComments: true is set. (@koic)

#13118: Fix a false positive for Style/MapIntoArray when splatting. (@earlopain)

#13105: Fix false positives for Style/ArgumentsForwarding when forwarding kwargs/block arg with non-matching additional args. (@koic)

#13139: Fix false positives for Style/RedundantCondition when using modifier if or unless. (@koic)

#13134: Fix false negative for Lint/Void when using using frozen literals. (@vlad-pisanov)

#13148: Fix incorrect autocorrect for Lint/EmptyConditionalBody when missing elsif body with end on the same line. (@koic)

#13109: Fix an error for the Lockfile parser when it contains incompatible BUNDLED WITH versions. (@earlopain)

#13112: Fix detection of TargetRubyVersion through the gemfile if the gemfile ruby version is below 2.7. (@earlopain)

#13155: Fixes an error when the server cache directory has too long path, causing rubocop to fail even with caching disabled. (@protocol7)

Changes

#13050: Allow get_!, set_!, get_?, set_?, get_=, and set_= in Naming/AccessorMethodName. (@koic)

#13103: Make Lint/UselessAssignment autocorrection safe. (@koic)

#13099: Make Style/RedundantRegexpArgument respect the EnforcedStyle of Style/StringLiterals. (@koic)

#13165: Remove dependency on the rexml gem. (@bquorning)

#13090: Require RuboCop AST 1.32.0+ to use RuboCop::AST::RationalNode. (@koic)

1.65.1

New features

#13068: Add config validation to Naming/PredicateName to check that all ForbiddenPrefixes are being checked. (@maxjacobson)

Bug fixes

#13051: Fix an error for Lint/FloatComparison when comparing with rational literal. (@koic)

#13065: Fix an error for Lint/UselessAssignment when same name variables are assigned using chained assignment. (@koic)

#13062: Fix an error for Style/InvertibleUnlessCondition when using empty parenthesis as condition. (@earlopain)

#11438: Explicitly load fileutils before calculating before_us. (@r7kamura)

#13044: Fix false negatives for Lint/ImplicitStringConcatenation when using adjacent string interpolation literals on the same line. (@koic)

#13083: Fix a false positive for Style/GlobalStdStream when using namespaced constants like Foo::STDOUT. (@earlopain)

#13081: Fix a false positive for Style/ZeroLengthPredicate when using safe navigation and non-zero comparison. (@fatkodima)

#13041: Fix false positives for Lint/UselessAssignment when pattern match variable is assigned and used in a block. (@koic)

#13076: Fix an incorrect autocorrect for Naming/RescuedExceptionsVariableName when using hash value omission. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ i18n (indirect, 1.14.5 → 1.14.6) · Repo · Changelog

Release Notes

1.14.6

What's Changed

Ruby < 3.2 support will be dropped April 2025. Upgrade now to continue using i18n after that date.

fix issues with RDoc generation by @davetron5000 in #698

Fix loading of .rb locale files when load_path is not a string by @stevegeek in #701

Fixes strings being interpolated multiple times by @alexpls in #699

Optimize pluralization logic in test data by @zachmargolis in #697

[FIX] Raise ArgumentError on nil key in exists? by @KinWang-2013 in #696

New Contributors

@davetron5000 made their first contribution in #698

@stevegeek made their first contribution in #701

@alexpls made their first contribution in #699

@zachmargolis made their first contribution in #697

@KinWang-2013 made their first contribution in #696

Full Changelog: v1.14.5...v1.14.6

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 12 commits:

↗️ parallel (indirect, 1.25.1 → 1.26.3) · Repo

Commits

See the full diff on Github. The new version differs by 10 commits:

↗️ parser (indirect, 3.3.4.0 → 3.3.5.0) · Repo · Changelog

Release Notes

3.3.5.0 (from changelog)

API modifications:

Bump maintenance branches to 3.3.5 (#1039) (Koichi ITO)

3.3.4.1 (from changelog)

API modifications:

Bump 3.2 branch to 3.2.5. (#1036) (Ilya Bylich)

Bump Racc to 1.8.1 (#1031) (Koichi ITO)

Bugs fixed:

builder.rb: catch encoding errors when parsing invalid encoding regexp (#1033) (Earlopain)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 15 commits:

↗️ rubocop-ast (indirect, 1.31.3 → 1.32.3) · Repo · Changelog

Release Notes

1.32.3 (from changelog)

Bug fixes

#310: Fix RuboCop::AST::DefNode#void_context? to handle class methods called initialize. ([@vlad-pisanov][])

1.32.1 (from changelog)

Changes

#309: Mark RuboCop::AST::EnsureNode as being in a void context. (@earlopain)

1.32.0 (from changelog)

New features

#304: Add RuboCop::AST::RationalNode. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 31 commits:

↗️ unicode-display_width (indirect, 2.5.0 → 2.6.0) · Repo · Changelog

Release Notes

2.6.0 (from changelog)

Unicode 16

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 7 commits:

🗑️ strscan (removed)

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands

@depfu rebase
Rebases against your default branch and redoes this update

@depfu recreate
Recreates this PR, overwriting any edits that you've made to it

@depfu merge
Merges this PR once your tests are passing and conflicts are resolved

@depfu cancel merge
Cancels automatic merging of this PR

@depfu close
Closes this PR and deletes the branch

@depfu reopen
Restores the branch and reopens this PR (if it's closed)

@depfu pause
Ignores all future updates for this dependency and closes this PR

@depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR

@depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

Update rubocop-rails to version 2.26.2

b2493dd

depfu bot added the depfu Automatic PRs to update gems label Sep 28, 2024

depfu bot mentioned this pull request Sep 28, 2024

Update rubocop-rails 2.24.1 → 2.26.0 (minor) #3450

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update rubocop-rails 2.24.1 → 2.26.2 (minor) #3453

Update rubocop-rails 2.24.1 → 2.26.2 (minor) #3453

depfu bot commented Sep 28, 2024

Update rubocop-rails 2.24.1 → 2.26.2 (minor) #3453

Are you sure you want to change the base?

Update rubocop-rails 2.24.1 → 2.26.2 (minor) #3453

Conversation

depfu bot commented Sep 28, 2024

What changed?

✳️ rubocop-rails (2.24.1 → 2.26.2) · Repo · Changelog

Bug fixes

Changes

Bug fixes

Changes

New features

Bug fixes

Changes

Bug fixes

Changes

New features

Bug fixes

Changes

✳️ rexml (3.3.6 → 3.3.7) · Repo · Changelog

Improvements

Thanks

✳️ rubocop (1.65.0 → 1.66.1) · Repo · Changelog

Bug fixes

New features

Bug fixes

Changes

New features

Bug fixes

↗️ i18n (indirect, 1.14.5 → 1.14.6) · Repo · Changelog

What's Changed

New Contributors

↗️ parallel (indirect, 1.25.1 → 1.26.3) · Repo

↗️ parser (indirect, 3.3.4.0 → 3.3.5.0) · Repo · Changelog

3.3.5.0 (from changelog)

3.3.4.1 (from changelog)

↗️ rubocop-ast (indirect, 1.31.3 → 1.32.3) · Repo · Changelog

1.32.3 (from changelog)

Bug fixes

1.32.1 (from changelog)

Changes

1.32.0 (from changelog)

New features

↗️ unicode-display_width (indirect, 2.5.0 → 2.6.0) · Repo · Changelog

2.6.0 (from changelog)

🗑️ strscan (removed)