A new build of javascript files to fix the counter for leap 15.6 #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* gulp-uglify was no longer building minimal js as the vendor scripts are using octal numbers
lkocman
changed the title
ddemaio
changed the title
|
Will ping @lkocman on first week or second week of July |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should always ask people to publish screenshot of the change. The last counter changes did not actually provide the built/minimized javascript files (see gulp in readme).
The big problem was that recent gulp-uglify no longer worked so we have to use gulp-uglify-es https://www.npmjs.com/package/gulp-uglify-es
Please always make sure to commit stuff built by gulp
node_modules/.bin/gulp