Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SDK injection into initContainers #3308

Open
Joibel opened this issue Sep 27, 2024 · 0 comments
Open

Allow SDK injection into initContainers #3308

Joibel opened this issue Sep 27, 2024 · 0 comments
Labels
enhancement New feature or request needs triage

Comments

@Joibel
Copy link

Joibel commented Sep 27, 2024

Component(s)

auto-instrumentation

Is your feature request related to a problem? Please describe.

I am adding tracing to argo-workflows to allow collection of a trace of the actual workflow.

When a workflow executes a workload in a pod it will create the pod with an initContainer which does various bits of setup of the workflow, including downloading of any artifacts (files) which the pod may use during execution.

I would like to be able to capture this as part of the overall workflow trace.

Describe the solution you'd like

When a container-names annotation is present on a pod I would like the SDK environment variables to be present in the initContainers whose names are present in the annotation.

Describe alternatives you've considered

I can manually inject the constant SDK variables, but this is also the case for anyone using the operator annotations for SDK injection. I would like the convenience of the operator to help me here too, especially for the non-constant values.

Additional context

I have a POC which does this. The code change is relatively small. I am willing to make the PR.

I am unsure whether any of the specific injectors should also honor this on initContainers - so would like guidance on that.

@Joibel Joibel added enhancement New feature or request needs triage labels Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage
Projects
None yet
Development

No branches or pull requests

1 participant