Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the parameters to what the Manifest generation process needs #3266

Open
taniyourstruly opened this issue Sep 5, 2024 · 0 comments
Open
Labels
enhancement New feature or request needs triage

Comments

@taniyourstruly
Copy link
Contributor

Component(s)

collector

Is your feature request related to a problem? Please describe.

From #2399, many objects are passed to the builder via the Params struct and we don't want any unnecessary feedback being given by the validation webhook. We should restrict the params to what the manifest generation process actually needs by only passing those params to the builders.

Describe the solution you'd like

Limit the amount of parameters we pass to the builders.

Describe alternatives you've considered

No response

Additional context

No response

@taniyourstruly taniyourstruly added enhancement New feature or request needs triage labels Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage
Projects
None yet
Development

No branches or pull requests

1 participant