Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README documentation for <SecureRoute> incompatibility with React Router v6 #267

Open
gavinr-maps opened this issue Sep 8, 2023 · 2 comments · Fixed by #275
Open
Labels
bug Something isn't working

Comments

@gavinr-maps
Copy link

Describe the bug

It was discussed here that <SecureRoute> cannot be used with React Router v6. This fact was confirmed by @jaredperreault-okta here, and Jared linked to this sample which does not use the <SecureRoute> component.

Based on the above, <SecureRoute> is not compatible with React Router v6. Given that React Router v6 has been out for almost 2 years, I think the documentation in this project's README should assume that users are using React Router v6 (and thus cannot use <SecureRoute> 😟). That involves:

  1. Updating this sample:
    image
  2. Updating the wording here
    image

Reproduction Steps?

See the README links above.

SDK Versions

n/a

Additional Information

No response

@gavinr-maps gavinr-maps added the bug Something isn't working label Sep 8, 2023
@Lcharvol
Copy link

Someone is working on this bug? react-router v6 is up since 2 years now...

@guushamann
Copy link

2,5 years now...

This was linked to pull requests Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants