Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributors should be able to publish CI results without permissions #1038

Open
andychu opened this issue Dec 6, 2021 · 6 comments
Open

Comments

@andychu
Copy link
Contributor

andychu commented Dec 6, 2021

Right now it requires an SSH key.

I think we need a simple CGI upload program that accepts 3 files: JSON, TSV, and ZIP. (honestly PHP is the best at this for multi-file uploads).

And then it will call the Python program to rewrite the index.

This will also solve #1015

We have to be careful about the atomic rewrite of the index.

@andychu andychu added the c-i label Dec 6, 2021
@andychu
Copy link
Contributor Author

andychu commented Dec 6, 2021

We should also rename it to build.oilshell.org when we do this. Then we can be securely "multi-tenant" without multiple subdomains

Actually it is bad if anyone can publish HTML to our subdomain ... so we still need some kind of auth. I think a manual password file is OK.

Or maybe we can authenticate with github accounts somehow?

@andychu
Copy link
Contributor Author

andychu commented Dec 15, 2021

Need four passwords with access to publish into 4 directories:

  1. sourcehut/
  2. github/
  3. circle-ci/
  4. cirrus-ci/

And then rewrite the dashboard in that directory.

I guess that means contributors can get the password? As long as they can only add, it's mostly OK

andychu pushed a commit that referenced this issue Dec 15, 2021
Turned up https://builds.oilshell.org/

To receive build results from multiple services.  Working toward #1038.
@andychu
Copy link
Contributor Author

andychu commented May 30, 2022

Should we have a "docs" task?

It would be nice if it could just run alone ... without the cpp and everything

@andychu andychu changed the title Contributors should be able to publish CI results Contributors should be able to publish CI results without permissions Jun 21, 2022
@andychu
Copy link
Contributor Author

andychu commented Jun 21, 2022

We can simply add contributors to the repo, but I'd like them to be able to do so with less permissions ... I guess there should be a separate auth secret for travis-ci.oilshell.org ?

  • They don't need to be able to SSH and write files. The /status-api/github thing
  • But they should be able to publish JSON, TSV, and .wwz, and then rewrite the jobs index.
    • So I think this could go in some sort of PHP script that does auth and invokes shell ...
    • or really this would be a great use case for Oil ... maybe we should be ambitious and use a build of Oil
    • It should be a simple CGI. But I also want logging? CGI logging is not good. I want a process ID and task ID etc.

@andychu
Copy link
Contributor Author

andychu commented Aug 7, 2022

This is a little messed up now, we have to add people explicitly as contributors

It would be nice to do this for PRs from anyone

andychu pushed a commit that referenced this issue Sep 7, 2022
It produces some spew.  But we still need non-contributors to be able to
push.  Hm.

Related to #1038.

[metrics] minor typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant