Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow distro to be mandatory dependency only on Linux #15

Closed
jayvdb opened this issue Oct 13, 2019 · 0 comments · Fixed by #16
Closed

Allow distro to be mandatory dependency only on Linux #15

jayvdb opened this issue Oct 13, 2019 · 0 comments · Fixed by #16

Comments

@jayvdb
Copy link
Contributor

jayvdb commented Oct 13, 2019

Distro doesnt support Windows, and lots of other platforms, so it is a no-op on those platforms. python-distro/distro#177

Making it a hard dependency means it needs to be packaged for those platforms, and that can be a hard pill to swallow for packagers as the package is a useless extra chunk of maintenance.
jayvdb added a commit to jayvdb/userpath that referenced this issue Oct 15, 2019
@jayvdb
Make distro dependency optional
484cae0 
The distro package only supports Linux, and it is only used
here to detect Ubuntu.  Make it an optional dependency in the
code, so that packagers can exclude it when it isnt needed.

Closes ofek#15
@jayvdb jayvdb mentioned this issue Oct 15, 2019
Merged
jayvdb added a commit to jayvdb/userpath that referenced this issue Oct 15, 2019
@jayvdb
Make distro dependency optional
b0a5565 
The distro package only supports Linux, and it is only used
here to detect Ubuntu.  Make it an optional dependency in the
code, so that packagers can exclude it when it isnt needed.

Closes ofek#15
jayvdb added a commit to jayvdb/userpath that referenced this issue Oct 15, 2019
@jayvdb
Make distro dependency optional
1d76734 
The distro package only supports Linux, and it is only used
here to detect Ubuntu.  Make it an optional dependency in the
code, so that packagers can exclude it when it isnt needed.

Closes ofek#15
@ofek ofek closed this as completed in #16 Oct 15, 2019
ofek pushed a commit that referenced this issue Oct 15, 2019
@jayvdb @ofek
Make distro dependency optional (#16)
ab0b321 
The distro package only supports Linux, and it is only used
here to detect Ubuntu.  Make it an optional dependency in the
code, so that packagers can exclude it when it isnt needed.

Closes #15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make distro dependency optional jayvdb/userpath
1 participant
@jayvdb