Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference of stratified thermal storage to capacity model or fully mixed model not clear #100

Open
jnnr opened this issue Apr 8, 2020 · 5 comments
Assignees

Comments

@jnnr
Copy link
Member

jnnr commented Apr 8, 2020

There is no clear data or figure that helps to choose if one wants to use the stratified thermal storage or a simpler model for thermal storages. The plots coming out of examples/stratified_thermal_storage.py give an idea about the difference in the concept, but not about the consequences of choosing this component.

Running a typical model with a simple vs. stratified thermal storage for a whole year would help to quantify the differences.

@jnnr jnnr added this to the v0.0.3 milestone Apr 9, 2020
@c-moeller c-moeller modified the milestones: v0.0.3, v0.0.4 Jun 22, 2020
@c-moeller
Copy link
Member

@jakob-wo this topic could be related to the validation of the thermal storage

I'm going to shift this to v0.0.4 for now due to many other open issues in v0.0.3

@jakob-wo
Copy link
Contributor

@c-moeller I do not see a connection to the validation (with measurement data). It rather seems to be about new or adapted examples that show the differences between two models.

@jnnr
Copy link
Member Author

jnnr commented Jun 22, 2020

I agree with @c-moeller. It is a main motivation of validation to be able to tell if a simple model is good enough or if the next level of complexity is necessary. If two models yield pretty similar results and both fit the data, you would always choose the simpler one.

@jakob-wo
Copy link
Contributor

I understand your interpretation of validation and I agree that a model comparision is essential but that is not what I am working on right now.
The comparision between "simple" and "complex" model is part of the docu already: Stratified thermal storage (see Fig. 2).
I agree that this part should be improved to highlight in what cases the "more complex" model can be an advantage. To me that is an improvement of the docu and perhaps of the examples.

@c-moeller
Copy link
Member

Could be completed within the pv-heatpump simulations in the GRECO project.

@c-moeller c-moeller removed this from the v0.0.4 milestone Oct 1, 2020
@c-moeller c-moeller assigned c-moeller and unassigned jnnr Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants