Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn & reset fw policy if limit is updated #953

Open
5 tasks done
xmo-odoo opened this issue Sep 16, 2024 · 0 comments
Open
5 tasks done

Warn & reset fw policy if limit is updated #953

xmo-odoo opened this issue Sep 16, 2024 · 0 comments
Labels

Comments

@xmo-odoo
Copy link
Collaborator

xmo-odoo commented Sep 16, 2024

odoo/enterprise#68916 got very confusing as after disabling forwardport the limit was reset yet it was not forwardported.

The answer is that since 7711d09 these are now two completely different items, and the limit is updated independently from the forward port policy (because PRs of the same batch can have different limits).

So when the limit was updated, it had no effect as the limit was already False ~ master. Thankfully the post-merge resumption did not check the forward-port policy, so went through.

  • if the limit is updated on a PR in fw=no, notify the user
  • if the limit is updated on a PR in fw=no, reset to fw=default
  • check forward port policy in _maybe_update_limit, currently it unconditionally creates a forward-port task if the tip of the chain is merged (e.g. if the tip of the chain is the source and forward porting was disabled) which is inconsistent: if the tip is not merged then it just schedules a followup which does check for the policy
  • perform forward-porting if fw is updated from no to default after merge, the same way up to does.
  • check ACLs to make sure fw=default can be invoked by the PR author to reset from fw=no
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: done
Development

No branches or pull requests

1 participant