Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

staging timeouts are bumped way more than they should #952

Open
xmo-odoo opened this issue Sep 16, 2024 · 0 comments
Open

staging timeouts are bumped way more than they should #952

xmo-odoo opened this issue Sep 16, 2024 · 0 comments
Labels

Comments

@xmo-odoo
Copy link
Collaborator

Probably because of the switch, the trigger for bumping timeouts is increased way beyond what it should: originally the intent was to set the start of the timeout on the latest build start in order to account for large runbot queues: a staging can be created then if the runbot has crazy amounts of load the build is only picked up half an hour later, which should not count in the mergebot's timeout.

So the intent was every time we receive a "pending" status (which generally marks the start of a runbot build) we bump the timeout to account for the possibility of ci/runbot or ci/l10n timing getting a late start.

However with the statuses refactoring the timeout bump now occurs any time a _compute_state results in a pending, this means not just new pending statuses but also all success statuses except for the very last one.

This is obviously not what was ever expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: done
Development

No branches or pull requests

1 participant