Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container image doesn't get updated on plugin change #6

Closed
dsavchenko opened this issue Apr 27, 2023 · 4 comments
Closed

Container image doesn't get updated on plugin change #6

dsavchenko opened this issue Apr 27, 2023 · 4 comments
Assignees

Comments

@dsavchenko
Copy link
Member

At least dispatcher-plugin-nb2workflow didn't trigger container update

@dsavchenko
Copy link
Member Author

@volodymyrss the dispatcher container was not rebuilt after merging PR to the dispatcher-app on Sunday and yesterday's merging of PR to the plugin. Probably you could tweak the build?

@volodymyrss
Copy link
Member

the build is triggered by the same oda-bot and sometimes it looses connection.

the container build is site-specific since we originally wanted to have separate containers for different sites, with different plugins.

but since you are using unige-built images we can just make at least one default image in this repository here. triggers since can be done in a similar way to oda-hub/oda-bot#16 but it can be done without any extra service, will see. a service is useful for other things though, so maybe it's not bad to keep it.

the build is starting but having some issues with diskpressure. It should complete soon.

@dsavchenko
Copy link
Member Author

the container build is site-specific since we originally wanted to have separate containers for different sites, with different plugins.

As we already have a mechanism to disable dispatcher plugins, the same containers can be used most of the time

@volodymyrss
Copy link
Member

Dispatcher container is quite big which is a limiting factor in the deployment. One of the ways to reduce it is to have less plugins to have less dependencies. But for now it does not matter because of who uses it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants