Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings while compiling. #457

Open
dannywillems opened this issue Dec 30, 2016 · 1 comment
Open

Remove warnings while compiling. #457

dannywillems opened this issue Dec 30, 2016 · 1 comment

Comments

@dannywillems
Copy link
Member

Because warnings are evil and are ugly.
Some comes from eliom_form about type inference, some comes from cmx missing for Ocsipersist. some from unused rec flag, etc.

@vasilisp
Copy link
Contributor

vasilisp commented Jan 5, 2017

Warnings are just warnings, and we have looked at the remaining ones.

We would need to do ugly things to get rid of the type inference warnings. I personally prefer the warnings as a reminder to get to #459 sooner.

The cmx should be easy to fix in Ocsigen Server.

The rec flag warning is the fault of ppx_deriving_json. If I remember correctly, it was not possible to annotate let bindings to prevent the warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants