Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log BLOCK_JOB_COMPLETED error #395

Open
dupondje opened this issue Jun 29, 2023 · 1 comment
Open

Log BLOCK_JOB_COMPLETED error #395

dupondje opened this issue Jun 29, 2023 · 1 comment

Comments

@dupondje
Copy link
Member

The BLOCK_JOB_COMPLETED event contains some additional info and and error message when something failed.
It would be useful to include the error message somewhere in vdsm/ovirt.

Line from libvirt logs:

4114448: info : qemuMonitorJSONIOProcessLine:205 : QEMU_MONITOR_RECV_EVENT: mon=0x7f1a9c0082f0 event={"timestamp": {"seconds": 1688026018, "microseconds": 64056}, "event": "BLOCK_JOB_COMPLETED", "data": {"device": "commit-sdb-libvirt-2-format", "len": 73747988480, "offset": 7143424, "speed": 0, "type": "commit", 
"error": "No space left on device"}}
@nirs
Copy link
Member

nirs commented Mar 6, 2024

@dupondje If this info is passed to vdsm in the event, vdsm can log it. You can check how vdsm handles the event and if we have more info in the event here:

def dispatchLibvirtEvents(self, conn, dom, *args):

BrooklynDewolf added a commit to BrooklynDewolf/vdsm that referenced this issue Jun 4, 2024
Fixes oVirt#395

This change logs error messages related to the VIR_DOMAIN_EVENT_ID_BLOCK_JOB_2 in VDSM.

Signed-off-by: Brooklyn Dewolf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants