Bus Cleanup on Exit

[skrusty]

Currently, when the proxy is shutdown, there's no cleanup of queues still active/open.

[blitzrage]

@skrusty so thinking through this, I don't think having this close the topics/queues on proxy shut down actually makes sense, and let me explain why.

So in the future we will likely want to have the ability to let a proxy hand off existing control of the various topics/queues to another proxy. This may be as simple as load balancing, or perhaps you want to upgrade an existing proxy in a container and hand off the existing things to that proxy.

Additionally, if you are closing down a proxy, it's still possible that the information the proxy put on the topics/queues is still relevant and useful for the running applications, which could continue to parse and operate without the proxy in the background.

With that being said, adding some methods to the AppInstance in the go-ari-library does make sense (e.g. StopConsumer, StopProducer) in order to allow a graceful close of the topics/queues. So with those methods being available, the closure of the topics/queues would actually be deferred to the application layer, and not the proxy layer.

This of course doesn't help you too much since you're writing in .NET, however I think this thought process was useful, and will result in some code on the go-ari-proxy for closure of the topics on application close or shutdown in the future.