Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API proposal: DELETE /internal/vcr/v2/holder/{subjectID}/vc/{id} #3462

Open
gerardsn opened this issue Oct 8, 2024 · 3 comments
Open

API proposal: DELETE /internal/vcr/v2/holder/{subjectID}/vc/{id} #3462

gerardsn opened this issue Oct 8, 2024 · 3 comments

Comments

@gerardsn
Copy link
Member

gerardsn commented Oct 8, 2024

we currently have

DELETE /internal/vcr/v2/holder/{did}/vc/{id}

which is the only API that still uses {did}.

probably a 'nice to have' to make the API's consistent

@woutslakhorst
Copy link
Member

Since the ID of the VC is already enough, we could just change it to subject?

@gerardsn
Copy link
Member Author

gerardsn commented Oct 8, 2024

change what to subject?

  • we can't change the existing one without breaking current integrations?
  • The DELETE should only act on the holder and not the issuer

@woutslakhorst
Copy link
Member

we can introduce a REMOVE api ;) and deprecate the old one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants