Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync discovery service spec and implementation #3298

Open
gerardsn opened this issue Aug 6, 2024 · 3 comments
Open

sync discovery service spec and implementation #3298

gerardsn opened this issue Aug 6, 2024 · 3 comments
Assignees
Labels
Milestone

Comments

@gerardsn
Copy link
Member

gerardsn commented Aug 6, 2024

Add to implementation from spec (§3.4):

  • retractions must have type RetractedVerifiablePresentation
  • retraction and retracted VP must have the same expiration time
  • add support for PEX relational constraint feature is_holder and same_subject

change in spec (§4):

  • update requirement all credentials MUST have the same credentialSubject.id. If this is required, the PD should use PEX relational constraint feature same_subject
  • update requirement the key used to sign the presentation MUST be owned by the credential subject (see 4.1): the JWT kid header MUST reference an assertionMethod key from the subject's DID document.. Part of the requirement sounds like relational constraint feature is_holder .
  • add clarification on how all credentials in a VP are tied together
@gerardsn gerardsn added the rc issues for release candidate label Aug 6, 2024
@woutslakhorst woutslakhorst added this to the V6 milestone Sep 12, 2024
@woutslakhorst woutslakhorst added final and removed rc issues for release candidate labels Sep 12, 2024
@woutslakhorst
Copy link
Member

  • Add DiscoveryRegistrationCredential

@woutslakhorst woutslakhorst self-assigned this Sep 30, 2024
@woutslakhorst
Copy link
Member

is_holder and same_subject will not be implemented.

@woutslakhorst
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants