Numbas.jme.display.simplify returns '' if expression is empty

fixes numbas/editor#785
numbas · Aug 15, 2023 · 8311eeb · 8311eeb
1 parent 6387d40
commit 8311eeb
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/runtime/scripts/jme-display.js b/runtime/scripts/jme-display.js
@@ -110,6 +110,9 @@ jme.display = /** @lends Numbas.jme.display */ {
         parser = parser || Numbas.jme.standardParser;
         try {
             var exprTree = parser.compile(expr,{},true);    //compile the expression to a tree. notypecheck is true, so undefined function names can be used.
+            if(!exprTree) {
+                return '';
+            }
             return jme.display.simplifyTree(exprTree,ruleset,scope);    // simplify the tree
         } catch(e) {
             //e.message += '\nSimplifying expression failed. Expression was: '+expr;

diff --git a/tests/jme-runtime.js b/tests/jme-runtime.js
@@ -15914,6 +15914,9 @@ jme.display = /** @lends Numbas.jme.display */ {
         parser = parser || Numbas.jme.standardParser;
         try {
             var exprTree = parser.compile(expr,{},true);    //compile the expression to a tree. notypecheck is true, so undefined function names can be used.
+            if(!exprTree) {
+                return '';
+            }
             return jme.display.simplifyTree(exprTree,ruleset,scope);    // simplify the tree
         } catch(e) {
             //e.message += '\nSimplifying expression failed. Expression was: '+expr;

diff --git a/tests/numbas-runtime.js b/tests/numbas-runtime.js
@@ -15903,6 +15903,9 @@ jme.display = /** @lends Numbas.jme.display */ {
         parser = parser || Numbas.jme.standardParser;
         try {
             var exprTree = parser.compile(expr,{},true);    //compile the expression to a tree. notypecheck is true, so undefined function names can be used.
+            if(!exprTree) {
+                return '';
+            }
             return jme.display.simplifyTree(exprTree,ruleset,scope);    // simplify the tree
         } catch(e) {
             //e.message += '\nSimplifying expression failed. Expression was: '+expr;