Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tagging notifications in tree service #546

Closed
alexvanin opened this issue Jun 22, 2022 · 6 comments · Fixed by #598
Closed

Tagging notifications in tree service #546

alexvanin opened this issue Jun 22, 2022 · 6 comments · Fixed by #598
Assignees
@KirillovDenis
Labels
tree-service Implementing tree-service features U3 Regular

Comments

@alexvanin
Copy link
Contributor

alexvanin commented Jun 22, 2022 •
edited
Loading

In tree service branch, we can't use objInfo structure in notifications like we do on master branch after bd5fd04. The reason is that object tagging does not involve operations in object service anymore.

I have a couple proposals.

  1. Do not use data.ObjectInfo in SendNotificationsParams. Notification uses only a small subset of fields from ObjectInfo: name, size, version, etag (hash). Those can be defined in a separate structure which can be built based on ObjectInfo or from scratch.

  2. Specify version in tagging notifications. Version is available in request. Without (1) we have to parse version into object.ID and then set it in ObjectInfo. After (1) we can set version string directly.

  3. Check what field actually need to be specified. In some notifications like delete notifications we avoid size and etag. I guess it is okay, but can we avoid this info in tagging notifications?
@alexvanin
Copy link
Contributor Author

/cc @masterSplinter01 @KirillovDenis

@KirillovDenis
Copy link
Contributor

It seems it's one more case where we want to store size and etag in tree service.

@alexvanin
Copy link
Contributor Author

May be useful for multipart upload (check) and for expiration in #192 (comment).

@alexvanin
Copy link
Contributor Author

Blocked the same as #533 (comment)

@alexvanin
Copy link
Contributor Author

Unblocked due to #536 (comment)

@KirillovDenis KirillovDenis mentioned this issue Jul 18, 2022
Merged
masterSplinter01 pushed a commit that referenced this issue Jul 20, 2022
@KirillovDenis @masterSplinter01
[#546] Add size and etag in nodeVersionInfo
f5ecb94 
Signed-off-by: Denis Kirillov <[email protected]>
@KirillovDenis
Copy link
Contributor

Done in #598

@alexchetaev alexchetaev added the U3 Regular label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KirillovDenis KirillovDenis

Labels
tree-service Implementing tree-service features U3 Regular
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#546] Add size and etag in nodeVersionInfo KirillovDenis/neofs-s3-gw
3 participants
@alexvanin @KirillovDenis @alexchetaev