Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to edit output photo name #7

Open
edencakir opened this issue Jul 15, 2017 · 9 comments
Open

Option to edit output photo name #7

edencakir opened this issue Jul 15, 2017 · 9 comments

Comments

@edencakir
Copy link

Saved photos are always saved with a prefix 'rnimagetools', is there a way to avoid that?

@edencakir edencakir changed the title Option to edit "Edited photo name" Option to edit output photo name Jul 15, 2017
@srameshr
Copy link

srameshr commented Jul 15, 2017

@edencakir Are you able to save the images? For me, as soon as I click the done button the app crashes on IOS. Could you share me your implementation?

@edencakir
Copy link
Author

Ive only implemented for Android.

@edencakir
Copy link
Author

@srameshr can you post the stacktrace of the error?

@srameshr
Copy link

@edencakir I fixed it. It was permissions issue. BTW whats the increase in file size when u download the SDK? What will be the file size when you proguard compress it?

@edencakir
Copy link
Author

Nope, it's not a concern for my project. SDK is standard and can't do anything about it - unrelated to this repo.

@srameshr
Copy link

@edencakir I understand that. I just want to know whats the size the editor sdk adds to ur app.

@edencakir
Copy link
Author

edencakir commented Jul 19, 2017

APK size is 17 MB, I'm not sure how much of it is from SDK.

@npomfret
Copy link
Owner

Np plans to pass in an option for naming the photos. it easy enough to change them using rn-fetch-blob. Or submit a PR if you desperately want the feature.

@srameshr
Copy link

@npomfret Its not immediate. Passing tools option to the editor will be an awesome addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants