From 80e3072460d806a39d823db48d43bcce5b51c96c Mon Sep 17 00:00:00 2001 From: Stepan Lavrentev Date: Thu, 3 Oct 2024 18:55:18 +0300 Subject: [PATCH 1/2] fix: add myth delivery fee --- xcm/v6/transfers_dev.json | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/xcm/v6/transfers_dev.json b/xcm/v6/transfers_dev.json index ed9ff519a..10cae5590 100644 --- a/xcm/v6/transfers_dev.json +++ b/xcm/v6/transfers_dev.json @@ -607,6 +607,22 @@ "sizeFactor": "100000", "alwaysHoldingPays": false } + }, + "f6ee56e9c5277df5b4ce6ae9983ee88f3cbed27d31beeb98f9f84f997a1ab0b9": { + "toParent": { + "type": "exponential", + "factorPallet": "ParachainSystem", + "sizeBase": "300000000", + "sizeFactor": "100000", + "alwaysHoldingPays": false + }, + "toParachain": { + "type": "exponential", + "factorPallet": "XcmpQueue", + "sizeBase": "300000000", + "sizeFactor": "100000", + "alwaysHoldingPays": false + } } }, "networkBaseWeight": { From c152001ed19273388e92afd5b0db4dae84c71a78 Mon Sep 17 00:00:00 2001 From: Stepan Lavrentev Date: Fri, 4 Oct 2024 10:13:12 +0300 Subject: [PATCH 2/2] fix: count delivery fee --- scripts/print_xcm_changes.py | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/scripts/print_xcm_changes.py b/scripts/print_xcm_changes.py index 420a8a2e5..0bfa3e2e8 100644 --- a/scripts/print_xcm_changes.py +++ b/scripts/print_xcm_changes.py @@ -162,9 +162,42 @@ def compare_files(actual_json, new_json, chains_json): compare_destinations(changed_values, prod_chain_dict, new_chain_dict, chains_json_dict) + compare_network_delivery_fee( + changed_values, + actual_json.get('networkDeliveryFee', {}), + new_json.get('networkDeliveryFee', {}), + chains_json_dict + ) + return changed_values +def compare_network_delivery_fee(object_accumulator, actual_network_delivery_fee, new_network_delivery_fee, chains_json_dict): + """Compare network delivery fee between production and changed json + + Args: + object_accumulator (dict): This object accumulate all changes + actual_network_delivery_fee (dict): Dictionary with actual network delivery fee + new_network_delivery_fee (dict): Dictionary with changed network delivery fee + chains_json_dict (dict): Dictionary with chains.json + """ + for chain_id, fee_data in new_network_delivery_fee.items(): + chain_name = chains_json_dict[chain_id].get('name', chain_id) + if chain_id not in actual_network_delivery_fee: + object_accumulator['networkDeliveryFee'][chain_name] = 'Added' + else: + if fee_data != actual_network_delivery_fee[chain_id]: + object_accumulator['networkDeliveryFee'][chain_name] = { + 'old_value': actual_network_delivery_fee[chain_id], + 'new_value': fee_data + } + + for chain_id in actual_network_delivery_fee: + chain_name = chains_json_dict[chain_id].get('name', chain_id) + if chain_id not in new_network_delivery_fee: + object_accumulator['networkDeliveryFee'][chain_name] = 'Removed' + + def main(argv): """It will compare transfers.json from endpoint and local file, then print changes. Depends on parametrs it will print changes for dev or prod environment. Also it prepared as to run locally with default parameters, as to run in CI/CD pipeline with parameters from environment variables.