Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the API #22

Open
Yamakaky opened this issue Oct 18, 2020 · 0 comments
Open

Refactor the API #22

Yamakaky opened this issue Oct 18, 2020 · 0 comments

Comments

@Yamakaky
Copy link

Yamakaky commented Oct 18, 2020

Currently, everything is reexported from lib.rs. I'd rather have a division per file format, with each module having links to the format spec, basic examples... For example:

DeBin -> bin::Deserialize
DeBinErr -> bin::Error
DeJsonTok -> json::Token

Additionally, free functions could be moved from the traits to the module:

SerJson::serialize_json -> json::serialize
TomlParser::parse -> toml::parse (with a new type/struct Document = HashMap<String, Toml>)

I can do a PR if you are OK with it, after my other PR are merged or rejected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant