Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: missing save button on mobile #589

Open
sseppi opened this issue Aug 12, 2024 · 6 comments
Open

BUG: missing save button on mobile #589

sseppi opened this issue Aug 12, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@sseppi
Copy link
Contributor

sseppi commented Aug 12, 2024

  • Device: e.g. Mobile - Google Pixel 4a
  • Operating System: Android 13
  • Browser: Firefox 129.0
  • Problem Description:
    If I add/change something in one record the Save Button doesn't appear. The only way to save is try to exit from the record and than appeas the usaved data warning (see screenshot below).
    Screenshot_20240812-153043

Steps replicate the problem

  1. Access the Data Browser (testing environment: https://databrowser.opendatahub.testingmachine.eu/) on mobile
  2. Make the Login
  3. Access the "eCharging Station Accessibility" dataset: https://databrowser.opendatahub.testingmachine.eu/dataset/table/tourism/v1/ODHActivityPoi?tagfilter=electric+charging+stations
  4. Access the Edit Mode of one Station randomly: https://databrowser.opendatahub.testingmachine.eu/dataset/edit/tourism/v1/ODHActivityPoi/echarging_it*220*ebz000043
  5. Change randomly a data
  • Expected behaviour:
    Once the user changes something save and cancel button should appear, to save or undo the changes.
    See as example the red (red color only to remark my proposals) buttons I added to the screenshot below.
    Screenshot_20240812-144037 (seconda copia)
    @mmalfertheiner @pkritzinger : what do you think about my proposal.
@sseppi sseppi added the bug Something isn't working label Aug 12, 2024
@sseppi sseppi added this to the Data Browser 2.5 - Beta milestone Aug 12, 2024
@pkritzinger
Copy link
Collaborator

pkritzinger commented Aug 13, 2024

@sseppi agree. The screenshot below shows the expected behavior in the design.

image

@gappc
Copy link
Collaborator

gappc commented Aug 15, 2024

@sseppi @pkritzinger the buttons were visible at the bottom of the screen, after scrolling down. PR #592 fixes that issue, it should works as expected after the merge.

@gappc
Copy link
Collaborator

gappc commented Aug 18, 2024

@sseppi the PR was merged, should we close this ticket?

@gappc
Copy link
Collaborator

gappc commented Aug 19, 2024

@sseppi the PR #592 did not resolve the problem 100%, I need to take another look at it

@gappc
Copy link
Collaborator

gappc commented Aug 22, 2024

@sseppi
Copy link
Contributor Author

sseppi commented Aug 22, 2024

@sseppi please take a look at it e.g. https://9.databrowser.gappc.net/dataset/edit/tourism/v1/Accommodation/5E4BEFD440200CE4732A7FA30897C402

It should work now

@gappc now it seems to work properly, can you please close the PR #595 that is stil marked as Draft?
Then I will accept the PR you did and test it again in the testing environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants