Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark machines doesn't compare against v22.x #3866

Open
RafaelGSS opened this issue Aug 20, 2024 · 1 comment
Open

Benchmark machines doesn't compare against v22.x #3866

RafaelGSS opened this issue Aug 20, 2024 · 1 comment

Comments

@RafaelGSS
Copy link
Member

Hey folks,

We are trying to run benchmarks for nodejs/node#54452 but it's constantly failing. I suspect it's because benchmark machines don't have the v22.x branch reference.

The errors look like deps/amaro aren't fetched correctly, but the reason might be an outdated version of the code. See: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1611/consoleText

error: test/es-module/test-typescript-transform.mjs: does not exist in index
@targos
Copy link
Member

targos commented Aug 24, 2024

I'm not sure what's happening, but I think the job had no problem checking out and building the v22.x branch. The error happens when it tries to apply the patch from the release proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants