From bf4258e29e1ee90592b3f4615bb0608e464db4d7 Mon Sep 17 00:00:00 2001 From: Matteo Collina Date: Wed, 27 Dec 2023 14:15:17 +0100 Subject: [PATCH 1/7] Added minutes for 2023-11-29 meeeting Signed-off-by: Matteo Collina --- meetings/2023-11-29.md | 90 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 90 insertions(+) create mode 100644 meetings/2023-11-29.md diff --git a/meetings/2023-11-29.md b/meetings/2023-11-29.md new file mode 100644 index 00000000..8697e7a7 --- /dev/null +++ b/meetings/2023-11-29.md @@ -0,0 +1,90 @@ +# Node.js Technical Steering Committee (TSC) Meeting 2023-11-29 + +## Links + +* **Recording**: +* **GitHub Issue**: +* **Minutes Google Doc**: + +## Present + +* Michaël Zasso @targos (voting member) +* Yagiz Nizipli @anonrig (voting member) +* Gireesh Punathil @gireeshpunathil (voting member) +* Joyee Cheung @joyeecheung (voting member) +* Chengzhong Wu @legendecas (voting member) +* Matteo Collina @mcollina (voting member) +* Rafael Gonzaga @RafaelGSS (voting member) +* Darshan Sen @RaisinTen (voting member) +* Robert Nagy @ronag (voting member) +* Richard Lau @richardlau (voting member) +* Antoine du Hamel @aduh95 (voting member) +* Ruben Bridgewater @BridgeAR (voting member) + +## Agenda + +### Announcements + +\*Node.js v21.3.0 postponed because of bugs +\*Node.js v18.x last “big release” with 364 commits +-it will ship the new off-thread ESM module loader (if using ts-node you will need to change) + +### CPC and Board Meeting Updates + +\*Extracted from **tsc-agenda** labeled issues and pull requests from the **nodejs org** prior to the meeting. + +-The community fund has not been extended by the Board in 2023 + +### nodejs/node + +* build: use biome as formatter [#50672](https://github.com/nodejs/node/pull/50672) + * yagiz: 96% compatible with prettier + * yagiz: some concerns about binary size. + * yagiz: should we include a formatter of the JS code + * joyee: we should add a formatter that format diffs, instead of formatting full files, otherwise it would become very hard to backport. Biome does not currently support that. + * yagiz: there are some missing features: a. diff-based formatter (to add), b. binary files (can be resolved by using wasm). Biome can also be a dependency of ncu, similar to how we do the c++ linting. + * joyee: human verification is needed, CI must be run on the formatted code. + * matteo: will we remove eslint? + * yagiz: no + * joyee: lets install biome like we install clang-format +* util: move deprecated utils to runtime deprecation [#50488](https://github.com/nodejs/node/pull/50488) + * landed. +* The env var `NODE_V8_COVERAGE` intermittently causes the process to hang [#49344](https://github.com/nodejs/node/issues/49344) + +### nodejs/TSC + +* Update meeting times [#1469](https://github.com/nodejs/TSC/issues/1469) + * Proposal sent, will implement unless concerns by end of meeting +* Automating Flaky Test Detection [#1458](https://github.com/nodejs/TSC/issues/1458) + * richard: do we have any concern about security releases? + * joyee: what they need is sending the junit xml to the server, but it must be done in a safe way for security. Detecting flaky tests is not a problem (we already the automation), the problem is fixing them! If they do the work, no objection + * richard: this needs a champion on Build, because they would need the permissions to edit the Jenkins config. + * joyee: can we implement some automation to store them in git? + * richard: integrate something in our make script would make things significantly simpler. + * joyee: move the the build repo. + +### nodejs/admin + +* Have a mascot [#828](https://github.com/nodejs/admin/issues/828) + * the TSC is voting +* Create `nodejs/socket` repository for Node.js implementation of Cloudflare's Socket API [#826](https://github.com/nodejs/admin/issues/826) + * legendecas: WinterCG is still figuring out the process to publish standards. Not a blocker for creating a repo + * joyee: it likely make more sense to move that implementation in WinterCG + * legendecas: that would be the Node.js implementation for the socket standard + * joyee: polyfills are created in the same repo/org where they are developed. + * joyee to comment on the issue +* Events / Collaborator Summits for 2024 [#814](https://github.com/nodejs/admin/issues/814) + +## Strategic Initiatives + +-ronag: Node.js write corrupted files with IO\_URING is enabled. + +* legendecas: ShadowRealm supports user-land modules, next step is to decide on the built-in modules exposed in the ShadowRealm. + +Skip for today. + +## Upcoming Meetings + +* **Node.js Project Calendar**: + +Click `+GoogleCalendar` at the bottom right to add to your own Google calendar. From dd238cb19c02a202d5b6140d49012efc869d912b Mon Sep 17 00:00:00 2001 From: Matteo Collina Date: Sun, 31 Dec 2023 13:52:21 +0100 Subject: [PATCH 2/7] Update 2023-11-29.md Co-authored-by: Antoine du Hamel --- meetings/2023-11-29.md | 5 ----- 1 file changed, 5 deletions(-) diff --git a/meetings/2023-11-29.md b/meetings/2023-11-29.md index 8697e7a7..b81f65c0 100644 --- a/meetings/2023-11-29.md +++ b/meetings/2023-11-29.md @@ -83,8 +83,3 @@ Skip for today. -## Upcoming Meetings - -* **Node.js Project Calendar**: - -Click `+GoogleCalendar` at the bottom right to add to your own Google calendar. From a2dba6bdfea2cf689326cf09e72f776722c0f3a9 Mon Sep 17 00:00:00 2001 From: Matteo Collina Date: Sun, 31 Dec 2023 14:18:04 +0100 Subject: [PATCH 3/7] Update 2023-11-29.md Co-authored-by: Antoine du Hamel --- meetings/2023-11-29.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/meetings/2023-11-29.md b/meetings/2023-11-29.md index b81f65c0..b8eb75c0 100644 --- a/meetings/2023-11-29.md +++ b/meetings/2023-11-29.md @@ -25,9 +25,10 @@ ### Announcements -\*Node.js v21.3.0 postponed because of bugs -\*Node.js v18.x last “big release” with 364 commits --it will ship the new off-thread ESM module loader (if using ts-node you will need to change) +* Node.js v21.3.0 postponed because of bugs +* Node.js v18.19.0 last “big release” for 18.x + * 364 commits + * it will ship the new off-thread ESM module loader (might affect ts-node/tsx/etc. users) ### CPC and Board Meeting Updates From e98ea2eaf9a74cb6d0cb01f83db6145e3adf43fc Mon Sep 17 00:00:00 2001 From: Matteo Collina Date: Sun, 31 Dec 2023 14:18:14 +0100 Subject: [PATCH 4/7] Update 2023-11-29.md Co-authored-by: Antoine du Hamel --- meetings/2023-11-29.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/meetings/2023-11-29.md b/meetings/2023-11-29.md index b8eb75c0..3896ec32 100644 --- a/meetings/2023-11-29.md +++ b/meetings/2023-11-29.md @@ -78,8 +78,7 @@ ## Strategic Initiatives --ronag: Node.js write corrupted files with IO\_URING is enabled. - +* ronag: Node.js write corrupted files with IO\_URING is enabled. * legendecas: ShadowRealm supports user-land modules, next step is to decide on the built-in modules exposed in the ShadowRealm. Skip for today. From a9c09f9a3a115e550c7871f57af94d8bbd61fea3 Mon Sep 17 00:00:00 2001 From: Matteo Collina Date: Sun, 31 Dec 2023 14:18:23 +0100 Subject: [PATCH 5/7] Update 2023-11-29.md Co-authored-by: Antoine du Hamel --- meetings/2023-11-29.md | 1 - 1 file changed, 1 deletion(-) diff --git a/meetings/2023-11-29.md b/meetings/2023-11-29.md index 3896ec32..600a205a 100644 --- a/meetings/2023-11-29.md +++ b/meetings/2023-11-29.md @@ -32,7 +32,6 @@ ### CPC and Board Meeting Updates -\*Extracted from **tsc-agenda** labeled issues and pull requests from the **nodejs org** prior to the meeting. -The community fund has not been extended by the Board in 2023 From 1c5cad662539e528581aee6fd3fe9585d3419497 Mon Sep 17 00:00:00 2001 From: Matteo Collina Date: Sun, 31 Dec 2023 14:18:30 +0100 Subject: [PATCH 6/7] Update 2023-11-29.md Co-authored-by: Antoine du Hamel --- meetings/2023-11-29.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meetings/2023-11-29.md b/meetings/2023-11-29.md index 600a205a..e2de3f64 100644 --- a/meetings/2023-11-29.md +++ b/meetings/2023-11-29.md @@ -33,7 +33,7 @@ ### CPC and Board Meeting Updates --The community fund has not been extended by the Board in 2023 +* The community fund has not been extended by the Board in 2023 ### nodejs/node From 5e22c6aa4ef873a7db61b035cbc2bd038f30afd5 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Tue, 2 Jan 2024 15:04:42 -0500 Subject: [PATCH 7/7] make linter happy --- meetings/2023-11-29.md | 4 ---- 1 file changed, 4 deletions(-) diff --git a/meetings/2023-11-29.md b/meetings/2023-11-29.md index e2de3f64..dc7a0b4e 100644 --- a/meetings/2023-11-29.md +++ b/meetings/2023-11-29.md @@ -32,7 +32,6 @@ ### CPC and Board Meeting Updates - * The community fund has not been extended by the Board in 2023 ### nodejs/node @@ -79,6 +78,3 @@ * ronag: Node.js write corrupted files with IO\_URING is enabled. * legendecas: ShadowRealm supports user-land modules, next step is to decide on the built-in modules exposed in the ShadowRealm. - -Skip for today. -