Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case sensitiveness of the Bluetooth Address #29

Open
ouinouin opened this issue May 5, 2018 · 3 comments
Open

Case sensitiveness of the Bluetooth Address #29

ouinouin opened this issue May 5, 2018 · 3 comments

Comments

@ouinouin
Copy link

ouinouin commented May 5, 2018

Hi,
full issue here ont the cool node-red-contrib-eq3-bluetooth project : alikh31/node-red-contrib-eq3-bluetooth#10 (comment)

if you input a higher cased Mac address like 00:1A:22:0D:E9:B4 , this will lead the noble-device function discoverWithFilter (in utils.js from the noble-device JS libs) to never match with 00:1a:22:0d:e9:b4 as represented by noble. I suggest you to insert a function to force the letters to be lowerecased before passing it to the different discover functions in order to let the users of the library to have the freedom of Case sensitiveness of the Input.

@sandeepmistry
Copy link
Collaborator

@ouinouin the request sounds reasonable, do you have time to submit a pull request for it?

@ouinouin
Copy link
Author

ouinouin commented May 5, 2018

Hi, thanks for your positive feedback, unfortunately I have very few coding skills (it took me more than 7 hours to dig in the code and print some debugging infos to find this....) but i ll ask one friend used to JS to have a look together. If he has time , we ll send you a pull request within 2/3 weeks, otherwise I ll inform you in this thread.
Regards.

@ouinouin
Copy link
Author

hi, @sandeepmistry
here is the PR : #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants