Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation error parameters when stddev=0 #118

Open
nathanvaughan-NOAA opened this issue Mar 16, 2022 · 1 comment
Open

Implementation error parameters when stddev=0 #118

nathanvaughan-NOAA opened this issue Mar 16, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@nathanvaughan-NOAA
Copy link
Collaborator

Old versions of SS3 included implementation error parameters in the forecast for almost all scenarios. In the new versions of SS, implementation parameters are not included unless stddev is >0 in the forecast file. This is causing some old SS models to crash with no helpful debugging output regarding why. We can either catch this in the code and remove the parameters if needed or at least add a warning in the documentation/examples to add a value >0.

@nathanvaughan-NOAA nathanvaughan-NOAA added the bug Something isn't working label Mar 16, 2022
@k-doering-NOAA k-doering-NOAA self-assigned this Mar 16, 2022
@k-doering-NOAA
Copy link
Collaborator

We should check how 3.30.18 works, since that is the version of SS3 designed to work with SSMSE. This should be noted, but doesn't need to be fixed if not needed for 3.30.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants