Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German Punkt: more time units in ##number## word pattern #221

Open
adbar opened this issue Jul 30, 2024 · 0 comments
Open

German Punkt: more time units in ##number## word pattern #221

adbar opened this issue Jul 30, 2024 · 0 comments

Comments

@adbar
Copy link

adbar commented Jul 30, 2024

Hi, in cases like "3. Minute" the sentence wrongly ends at "3." according to Punkt.

I see you have an effective list of words (notably months) in packages/tokenizers/punkt_tab/german/collocations.tab but it is incomplete. It would be useful to add the following time expressions:

##number## sekunde
##number## minute
##number## stunde
##number## tag
##number## woche
##number## monat
##number## jahr

I'm not sure how to proceed, can I open a PR to change the file directly or are other steps involved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant