Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json context optimizations #25

Closed
wants to merge 16 commits into from
Closed

Conversation

JimBugwadia
Copy link

Duplicating upstream PR: kyverno#8322

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2023

Codecov Report

Merging #25 (55d075e) into main (033340b) will increase coverage by 0.00%.
The diff coverage is 47.55%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   35.81%   35.81%           
=======================================
  Files         313      314    +1     
  Lines       25057    25108   +51     
=======================================
+ Hits         8974     8993   +19     
- Misses      15193    15223   +30     
- Partials      890      892    +2     
Files Coverage Δ
pkg/engine/context/evaluate.go 56.75% <100.00%> (+0.94%) ⬆️
pkg/validation/policy/validate.go 53.57% <ø> (ø)
pkg/engine/utils/foreach.go 0.00% <0.00%> (ø)
pkg/engine/variables/vars.go 52.36% <85.71%> (+0.19%) ⬆️
pkg/engine/context/mock_context.go 0.00% <0.00%> (ø)
pkg/engine/utils/utils.go 0.00% <0.00%> (ø)
pkg/engine/jsonutils/convert.go 0.00% <0.00%> (ø)
pkg/engine/context/utils.go 57.89% <65.71%> (+19.65%) ⬆️
pkg/engine/context/context.go 44.39% <50.00%> (-1.77%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

JimBugwadia and others added 9 commits September 14, 2023 09:06
skip other checks if operations do not match

A Kuttl test corresponding to notary image verification is failing, but that is due to access to upstream Kyverno registry not being available to downstream CI. That is being tracked under https://nirmata.atlassian.net/browse/NDEV-17474.
Jmespath reuse interpreter

One notary verifyImages kuttl test is failing due to it requiring access to a private image under ghcr.io/kyverno. Raised https://nirmata.atlassian.net/browse/NDEV-17474 for that.
@anushkamittal2001
Copy link
Collaborator

Since this is in 1.12 upstream and 1.10 and 1.11 downstream, I think we can close this
cc @pns-nirmata

@anushkamittal2001 anushkamittal2001 deleted the json_context_optimizations branch August 27, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants