Add a function to check remote HTTP/2 setting MAX_CONCURRENT_STREAMS #123
Conversation
zuiderkwast
force-pushed
the
respect-remote-concurrency-limit
branch
from
c45173c
to
27901cc
Compare
|
Right I believe the missing spec and the todo are why it didn't move forward. The todo in particular should be done. Perhaps it's better to maintain a counter in the state than count streams manually, since we want only locally initiated streams. |
|
I did the todo and added a spec.
The local number of streams is never more than the total number of streams, so I added counting only if the total number reaches the limit. Thus, this is O(1) in hopefully most cases but O(n) in the worst case. Do you prefer storing a counter in the state? There are multiple places where streams are added to and removed from the state so it would add some complexity. |
|
Probably fine like this. |
|
Ping. This one is ready too. (Sorry for spamming.) |
This is to be used primarily by a client before initiating a new stream so that it can respect the setting from the server.
zuiderkwast
force-pushed
the
respect-remote-concurrency-limit
branch
from
cbf5b1b
to
aacfd1b
Compare
This is to be used primarily by a client before initiating a new stream so that it can respect the setting from the server. Merged PR: ninenines#123
If the number of streams has reached the server setting MAX_CONCURRENT_STREAMS, new requests result in a stream error too_many_streams. This allows the user to handle the situation, e.g. to retry the request later or to send it on a different connection. Depends on ninenines/cowlib#123 which is included in: https://github.com/Nordix/cowlib/releases/tag/2.13.0-nordix1 Merged PR: ninenines#280
This is to be used primarily by a client before initiating a new stream
so that it can respect the setting from the server.
I've tested in in a draft patch to gun. Will post a gun PR soon.