Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require either redis or dalli but not both #3

Open
jeremywadsack opened this issue Jun 4, 2018 · 2 comments · May be fixed by #18
Open

Require either redis or dalli but not both #3

jeremywadsack opened this issue Jun 4, 2018 · 2 comments · May be fixed by #18

Comments

@jeremywadsack
Copy link
Contributor

Right now, your gemspec has the following:

  spec.add_dependency "dalli"
  spec.add_dependency "redis"

We only use Redis as a backend, not Memcached. Adding the dependency on dalli bloats our code.

Would it be possible to make this a dynamic dependency? It seems that the Gemfile using Suo is likely to already have redis or dalli included, so can you just skip the dependencies and load them on-demand? (You'd still need them in development_dependencies for tests.) I think you'd need a note in the README about that requirement.
@nickelser
Copy link
Owner

this absolutely makes sense, and normally i would just do this, but i'm quite wary of breaking existing applications. i could detect one or the other, and raise if neither is found -- what do you think?

@jeremywadsack
Copy link
Contributor Author

Sure, using some begin ... resque ... end would make sense.

@doits doits linked a pull request Oct 15, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make installing dalli and redis gem optional doits/suo
2 participants
@jeremywadsack @nickelser