Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment component #793

Closed
nate-ni opened this issue Oct 20, 2022 · 1 comment
Closed

Comment component #793

nate-ni opened this issue Oct 20, 2022 · 1 comment
Labels
client request Client team would immediately benefit from this change new component Request for a new component

Comments

@nate-ni
Copy link
Contributor

nate-ni commented Oct 20, 2022

😯 Problem to Solve

I high-order component that allows users to comment.
Similar to what is seen right here in GitHub and also in apps like Azure DevOps.

Potentially also look at how Office and Adobe XD provide comments in their right rail. This may/may not be appropriate for our use but is worth researching.

💁 Proposed Solution

📋 Tasks
@nate-ni nate-ni added enhancement New feature or request triage New issue that needs to be reviewed client request Client team would immediately benefit from this change labels Oct 20, 2022
@jattasNI jattasNI added new component Request for a new component and removed enhancement New feature or request triage New issue that needs to be reviewed labels Oct 25, 2022
@vivinkrishna-ni vivinkrishna-ni mentioned this issue Jun 8, 2023
Open
38 tasks
@jattasNI
Copy link
Contributor

jattasNI commented Jun 8, 2023

As we've started working on #1288 we've decided that Nimble should include components for rich text editing, viewing, and a way to do @mentioning but we don't think it should compose these into higher level comment component with support for displaying multiple comments, buttons for modifying/deleting comments, or a connection to a back-end. Our rationale is that those commenting features are likely to have app-specific UX and be tied to app-specific layers like localization and back-end services.

So I'm closing this issue for now. If anyone would like to revisit this decision, feel free to re-open and re-start the discussion.

@rajsite rajsite closed this as not planned Won't fix, can't repro, duplicate, stale Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client request Client team would immediately benefit from this change new component Request for a new component
Projects
Nimble Design System Priorities
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rajsite @jattasNI @nate-ni