Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review nimble-components for leaked subscriptions #2393

Open
m-akinc opened this issue Sep 11, 2024 · 0 comments
Open

Review nimble-components for leaked subscriptions #2393

m-akinc opened this issue Sep 11, 2024 · 0 comments

Comments

@m-akinc
Copy link
Contributor

m-akinc commented Sep 11, 2024

🧹 Tech Debt

Recently, while investigating a memory leak, we discovered a couple places where we were not unsubscribing elements that had earlier subscribed for notifications. This contributed to the memory leak by holding references to those still-subscribed, dead elements.

We need to search the repo for calls to subscribe and make sure that there are matching calls to unsubscribe in the correct places.

One example that needs fixing is in table-column enum-base, as removeMappingObservers() is only called when replacing mapping observers. It should also be called when disconnecting the element.

@m-akinc m-akinc added tech debt triage New issue that needs to be reviewed labels Sep 11, 2024
@m-akinc m-akinc removed the triage New issue that needs to be reviewed label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Current Iteration
Development

No branches or pull requests

1 participant