Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating secondary and reverse button to use correct variable rather the darken #908

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Updating secondary and reverse button to use correct variable rather the darken #908

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
712e9d9
Updating secondary and reverse button to use correct variable rather …
Fenwick17 Dec 5, 2023
b4c07fe
Update CHANGELOG.md
Fenwick17 Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

- Updated header component unit tests ([PR 900](https://github.com/nhsuk/nhsuk-frontend/pull/900)).
- Fixed bug where the header didn't align with the main width container ([PR 902](https://github.com/nhsuk/nhsuk-frontend/pull/902)). This fixes [Issue 901](https://github.com/nhsuk/nhsuk-frontend/issues/901)
- Updating secondary and reverse buttosn to use their hover variable rather than darken
Fenwick17 marked this conversation as resolved.
Show resolved Hide resolved

## 8.0.2 - 19 October 2023

Expand Down
4 changes: 2 additions & 2 deletions packages/components/button/_button.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ $button-shadow-size: 4px;
box-shadow: 0 $button-shadow-size 0 $nhsuk-secondary-button-shadow-color;

&:hover {
background-color: darken($nhsuk-secondary-button-color, 10%);
background-color: $nhsuk-secondary-button-hover-color;
}

&:focus {
Expand Down Expand Up @@ -145,7 +145,7 @@ $button-shadow-size: 4px;
color: $nhsuk-reverse-button-text-color;

&:hover {
background-color: darken($nhsuk-reverse-button-color, 5%);
background-color: $nhsuk-reverse-button-hover-color;
color: $nhsuk-reverse-button-text-color;
}

Expand Down
Loading