Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align service name to logo in header #997

Open
anandamaryon1 opened this issue Aug 20, 2024 · 1 comment · May be fixed by #1000
Open

Align service name to logo in header #997

anandamaryon1 opened this issue Aug 20, 2024 · 1 comment · May be fixed by #1000
Labels
Enhancement: feature request New feature or request

Comments

@anandamaryon1
Copy link
Contributor

anandamaryon1 commented Aug 20, 2024

Whilst working on the 'Logged in header' (nhsuk/nhsuk-service-manual-community-backlog#192) with colleagues, we discussed the transactional header and service name placement. We feel that keeping the service name to the right of the NHS logo could save space in the header.

For example:

current proposed
image image
image image
image image

This alignment seems possible with flexbox by adding align-items: stretch to .nhsuk-header__container and align-items: centre to .nhsuk-header__transactional-service-name. In the examples I've also tweaked the logo size and service name line-height so that they align better.

Related issue: nhsuk/nhsuk-service-manual-community-backlog#16

@anandamaryon1 anandamaryon1 added the Enhancement: feature request New feature or request label Aug 20, 2024
@frankieroberto
Copy link
Contributor

@anandamaryon1 this looks great! Would be happy to help test a PR for this.

Could this also cover merging the transactional service name and the service name options into 1? Currently they are very similar, but the logo size is very slightly different. This could be a follow-up issue though, if we don’t want to conflate the two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement: feature request New feature or request
Projects
None yet
2 participants