Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a.nhsuk-button.nhsuk-button--reverse:visited text is invisible! #853

Open
adam-carruthers opened this issue Jan 31, 2023 · 1 comment
Open

Comments

@adam-carruthers
Copy link

adam-carruthers commented Jan 31, 2023

Bug Report

What is the issue?

Using the nhsuk CSS, if you have a button with

What steps are required to reproduce the issue?

If you have a button like this

<a class="nhsuk-button nhsuk-button--reverse BasePage_logoutButton__rc_BE" role="button" aria-disabled="false" draggable="false" href="https://www.google.com">I'm a button</a>

the CSS is such that the button is invisible when the link is visited. This is because the .nhsuk-button:visisted CSS is defined, and sets the text color to white, but the .nhs-button--reverse class sets the background color to white as well.

How it looks when the link is visited (no hover):

image

It should look like:

image

The fix to this issue would be to add a .nhs-button--reverse:visited class to the CSS to cover this edge case.

What was the environment where this issue occurred?

  • Device: Thinkpad
  • Operating System: Windows
  • Browser: Chrome
  • Browser version: 109.0.5414.120 (Official Build) (64-bit)
  • NHS.UK frontend package version: 6.2.0
  • Node version:
  • npm version:

Is there anything else you think would be useful in recreating the issue?

@mikemonteith
Copy link
Contributor

@talieScript is going to fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants